carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-306) block size info should be show in Desc Formatted and executor log
Date Fri, 14 Oct 2016 02:36:21 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573920#comment-15573920
] 

ASF GitHub Bot commented on CARBONDATA-306:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/230#discussion_r83349683
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
    @@ -252,6 +252,15 @@ private static long getMaxOfBlockAndFileSize(long blockSize, long
fileSize) {
         if (remainder > 0) {
           maxSize = maxSize + HDFS_CHECKSUM_LENGTH - remainder;
         }
    +    long setBlockSizeInMb = blockSize / CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR
/
    +            CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR;
    +    // actual file size may be less than 1KB or 1MB, need to classify.
    +    String readableFileSize = ByteUtil.convertByteToReadable(fileSize);
    +    long maxSizeInMb = maxSize / CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR /
    +            CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR;
    +    LOGGER.info("The configured block size is " + setBlockSizeInMb + " MB, " +
    --- End diff --
    
    Use the new function here to format readable 


> block size info should be show in Desc Formatted and executor log
> -----------------------------------------------------------------
>
>                 Key: CARBONDATA-306
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-306
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Jay
>            Priority: Minor
>
> when run desc formatted command, the table block size should be show, as well as in executor
log when run load command



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message