carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-302) 7. Add DataWriterProcessorStep which reads the data from sort temp files and creates carbondata files.
Date Thu, 27 Oct 2016 05:20:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610709#comment-15610709
] 

ASF GitHub Bot commented on CARBONDATA-302:
-------------------------------------------

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/251#discussion_r85267443
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactHandlerFactory.java
---
    @@ -0,0 +1,48 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.carbondata.processing.store;
    +
    +/**
    + * Factory class for CarbonFactHandler.
    + */
    +public final class CarbonFactHandlerFactory {
    +
    +  /**
    +   * Creating fact handler to write data.
    +   * @param model
    +   * @param handlerType
    +   * @return
    +   */
    +  public static CarbonFactHandler createCarbonFactHandler(CarbonFactDataHandlerModel
model,
    --- End diff --
    
    Yes, I don't see the advantage of using semaphore here because we are already using fixed
thread pool to control the threads. I will discuss with team and confirm whether it is needed.



> 7. Add DataWriterProcessorStep which reads the data from sort temp files and creates
carbondata files.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-302
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-302
>             Project: CarbonData
>          Issue Type: Sub-task
>            Reporter: Ravindra Pesala
>            Assignee: Ravindra Pesala
>             Fix For: 0.3.0-incubating
>
>
> Add DataWriterProcessorStep which reads the data from sort temp files and merge sort
it, and apply mdk generator on key and creates carbondata files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message