carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-276) Add trim option
Date Wed, 12 Oct 2016 01:40:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567233#comment-15567233
] 

ASF GitHub Bot commented on CARBONDATA-276:
-------------------------------------------

Github user eason-lyx commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/200#discussion_r82923303
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java
---
    @@ -102,8 +102,8 @@ public void initialize() throws IOException {
         parserSettings.setMaxColumns(
             getMaxColumnsForParsing(csvParserVo.getNumberOfColumns(), csvParserVo.getMaxColumns()));
         parserSettings.setNullValue("");
    -    parserSettings.setIgnoreLeadingWhitespaces(false);
    -    parserSettings.setIgnoreTrailingWhitespaces(false);
    +    parserSettings.setIgnoreLeadingWhitespaces(csvParserVo.getTrim());
    --- End diff --
    
    hi sujith
    i am thinking if user already trim the data with the option setting,then when user query
with some space filter,it would no getting result.



> Add trim option
> ---------------
>
>                 Key: CARBONDATA-276
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-276
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Lionx
>            Assignee: Lionx
>            Priority: Minor
>
> Fix a bug and add trim option.
> Bug: When string is contains LeadingWhiteSpace or TrailingWhiteSpace, query result is
null. This is because the dictionary ignore the LeadingWhiteSpace and TrailingWhiteSpace and
the csvInput dose not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message