carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-267) Set block_size for table on table level
Date Sun, 02 Oct 2016 18:31:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540771#comment-15540771
] 

ASF GitHub Bot commented on CARBONDATA-267:
-------------------------------------------

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/189#discussion_r81474992
  
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -124,6 +124,7 @@ struct TableSchema{
     	1: required string table_id;  // ID used to
     	2: required list<ColumnSchema> table_columns; // Columns in the table
     	3: required SchemaEvolution schema_evolution; // History of schema evolution of this
table
    +	4: optional i32 block_size
    --- End diff --
    
    @Zhangshunyu Actually need not change Schema for such extra properties which are being
added. We can directly store TABLE_PROPERTIES as a string key value pairs in thrift. So that
all such properties configuration parameters can be effectively handled without modifying
thrift in future. @jackylk please comment.


> Set block_size for table on table level
> ---------------------------------------
>
>                 Key: CARBONDATA-267
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-267
>             Project: CarbonData
>          Issue Type: New Feature
>    Affects Versions: 0.1.0-incubating
>            Reporter: zhangshunyu
>            Assignee: zhangshunyu
>             Fix For: 0.2.0-incubating
>
>
> Set block_size for table on table level



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message