carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-37) Support Date/Time format for Timestamp columns to be defined at column level
Date Wed, 26 Oct 2016 02:46:00 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607195#comment-15607195
] 

ASF GitHub Bot commented on CARBONDATA-37:
------------------------------------------

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/219#discussion_r85038702
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java
---
    @@ -117,9 +113,11 @@ private TimeStampDirectDictionaryGenerator() {
        * @return dictionary value
        */
       @Override public int generateDirectSurrogateKey(String memberStr) {
    -    SimpleDateFormat timeParser = new SimpleDateFormat(CarbonProperties.getInstance()
    -        .getProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
    -            CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT));
    +    SimpleDateFormat timeParser = threadLocal.get();
    +    if(timeParser == null){
    +      timeParser = new SimpleDateFormat(dateFormat);
    +      threadLocal.set(timeParser);
    +    }
         timeParser.setLenient(false);
    --- End diff --
    
    Please extract above codes to a new initial method,  and invoke this method in different
thread.
    It it not good to run these codes in generateDirectSurrogateKey method.



> Support Date/Time format for Timestamp columns to be defined at column level
> ----------------------------------------------------------------------------
>
>                 Key: CARBONDATA-37
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-37
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Vimal Das Kammath
>            Assignee: Lionx
>
> Carbon support defining the Date/Time format. But the configuration for the same is present
in carbon.properties and hence is global for all tables.
> This global configuration for timestamp format cannot support scenarios where different
tables or different Timestamp columns in the same table.
> Suggest to provide option in the create table DDL itself to define the format for each
Timestamp column. Also provide defaults so that users can create table with Timestamp columns
without having to always define the Date/Time format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message