Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
Date: Wed, 28 Sep 2016 14:39:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@carbondata.incubator.apache.org
Message-ID: <JIRA.13008060.1475011301000.687956.1475073560617@Atlassian.JIRA>
In-Reply-To: <JIRA.13008060.1475011301000@Atlassian.JIRA>
References: <JIRA.13008060.1475011301000@Atlassian.JIRA> <JIRA.13008060.1475011301060@arcas>
Subject: [jira] [Commented] (CARBONDATA-279) [DataLoading]Save a DataFrame
 to CarbonData file without writing CSV file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 28 Sep 2016 14:39:25 -0000


    [ https://issues.apache.org/jira/browse/CARBONDATA-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529848#comment-15529848 ] 

ASF GitHub Bot commented on CARBONDATA-279:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/203#discussion_r80932289
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala ---
    @@ -742,7 +742,8 @@ object GlobalDictionaryUtil extends Logging {
        */
       def generateGlobalDictionary(sqlContext: SQLContext,
                                    carbonLoadModel: CarbonLoadModel,
    -                               hdfsLocation: String): Unit = {
    +                               hdfsLocation: String,
    +                               dataFrame: Option[DataFrame] = None): Unit = {
    --- End diff --
    
    I think we can call dataFrame.rdd.cache inside this function, because there are 2 scan, dataframe can be re-used after the first scan.


> [DataLoading]Save a DataFrame to CarbonData file without writing CSV file
> -------------------------------------------------------------------------
>
>                 Key: CARBONDATA-279
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-279
>             Project: CarbonData
>          Issue Type: Improvement
>    Affects Versions: 0.1.0-incubating
>            Reporter: QiangCai
>            Assignee: QiangCai
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Directly save a DataFrame to CarbonData file without writing CSV file


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)