Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 22C5C200B83 for ; Sat, 17 Sep 2016 16:25:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 21814160ACD; Sat, 17 Sep 2016 14:25:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5A46C160ABB for ; Sat, 17 Sep 2016 16:25:24 +0200 (CEST) Received: (qmail 58818 invoked by uid 500); 17 Sep 2016 14:25:23 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 58809 invoked by uid 99); 17 Sep 2016 14:25:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Sep 2016 14:25:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2985DC0362 for ; Sat, 17 Sep 2016 14:25:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id o68bnneXaT5U for ; Sat, 17 Sep 2016 14:25:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A4C835FBD0 for ; Sat, 17 Sep 2016 14:25:21 +0000 (UTC) Received: (qmail 58652 invoked by uid 99); 17 Sep 2016 14:25:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Sep 2016 14:25:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BA4B42C0D57 for ; Sat, 17 Sep 2016 14:25:20 +0000 (UTC) Date: Sat, 17 Sep 2016 14:25:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@carbondata.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CARBONDATA-245) Actual Exception is getting lost in case of data dictionary file generation. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 17 Sep 2016 14:25:25 -0000 [ https://issues.apache.org/jira/browse/CARBONDATA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499119#comment-15499119 ] ASF GitHub Bot commented on CARBONDATA-245: ------------------------------------------- Github user ravikiran23 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/160#discussion_r79284253 --- Diff: core/src/main/java/org/apache/carbondata/core/writer/CarbonDictionaryWriterImpl.java --- @@ -199,7 +199,10 @@ public CarbonDictionaryWriterImpl(String hdfsStorePath, */ @Override public void close() throws IOException { if (null != dictionaryThriftWriter) { - writeDictionaryFile(); + // if stream is open then only need to write dictionary file. + if(dictionaryThriftWriter.isOpen()){ --- End diff -- fixed > Actual Exception is getting lost in case of data dictionary file generation. > ---------------------------------------------------------------------------- > > Key: CARBONDATA-245 > URL: https://issues.apache.org/jira/browse/CARBONDATA-245 > Project: CarbonData > Issue Type: Bug > Components: data-load > Reporter: ravikiran > Priority: Minor > > Actual Exception is getting lost in case of data dictionary file generation.getting the null pointer exception as in the finally block we are trying to write data to a null stream. -- This message was sent by Atlassian JIRA (v6.3.4#6332)