Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
Date: Fri, 23 Sep 2016 09:13:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@carbondata.incubator.apache.org
Message-ID: <JIRA.13002658.1473047774000.646870.1474622000797@Atlassian.JIRA>
In-Reply-To: <JIRA.13002658.1473047774000@Atlassian.JIRA>
References: <JIRA.13002658.1473047774000@Atlassian.JIRA> <JIRA.13002658.1473047774458@arcas>
Subject: [jira] [Commented] (CARBONDATA-208) User should be able to turn on
 and off the STATISTIC log
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 23 Sep 2016 09:13:34 -0000


    [ https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515883#comment-15515883 ] 

ASF GitHub Bot commented on CARBONDATA-208:
-------------------------------------------

Github user foryou2030 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/176#discussion_r80208061
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/QueryStatisticsRecorderImpl.java ---
    @@ -0,0 +1,172 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.core.carbon.querystatistics;
    +
    +import java.io.Serializable;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.carbondata.common.logging.LogService;
    +import org.apache.carbondata.common.logging.LogServiceFactory;
    +
    +import static org.apache.carbondata.core.util.CarbonUtil.printLine;
    +
    +/**
    + * Class will be used to record and log the query statistics
    + */
    +public class QueryStatisticsRecorderImpl implements QueryStatisticsRecorder,Serializable {
    +
    +  private static final LogService LOGGER =
    +      LogServiceFactory.getLogService(QueryStatisticsRecorderImpl.class.getName());
    +
    +  /**
    +   * serialization version
    +   */
    +  private static final long serialVersionUID = -5719752001674467864L;
    +
    +  /**
    +   * list for statistics to record time taken
    +   * by each phase of the query for example aggregation
    +   * scanning,block loading time etc.
    +   */
    +  private List<QueryStatistic> queryStatistics;
    +
    +  /**
    +   * query with taskd
    +   */
    +  private String queryIWthTask;
    +
    +  /**
    +   * lock for log statistics table
    +   */
    +  private static final Object lock = new Object();
    +
    +  public QueryStatisticsRecorderImpl(String queryId) {
    +    queryStatistics = new ArrayList<QueryStatistic>();
    +    this.queryIWthTask = queryId;
    +  }
    +
    +  /**
    +   * Below method will be used to add the statistics
    +   *
    +   * @param statistic
    +   */
    +  public synchronized void recordStatistics(QueryStatistic statistic) {
    +    queryStatistics.add(statistic);
    +  }
    +
    +  /**
    +   * Below method will be used to log the statistic
    +   */
    +  public void logStatistics() {
    +    for (QueryStatistic statistic : queryStatistics) {
    +      LOGGER.statistic(statistic.getStatistics(queryIWthTask));
    +    }
    +  }
    +
    +  /**
    +   * Below method will be used to show statistic log as table
    +   */
    +  public void logStatisticsAsTableExecutor() {
    +    synchronized (lock) {
    --- End diff --
    
    yes, i think no need lock. For executor, one task one recorder. 
    what do u think? @Vimal-Das 


> User should be able to turn on and off the STATISTIC log
> --------------------------------------------------------
>
>                 Key: CARBONDATA-208
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-208
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Jacky Li
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Currently there are many STATISTIC log for performance tuning purpose, but it should be configurable by the user.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)