Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
Date: Tue, 20 Sep 2016 07:29:21 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@carbondata.incubator.apache.org
Message-ID: <JIRA.13002658.1473047774000.613420.1474356561039@Atlassian.JIRA>
In-Reply-To: <JIRA.13002658.1473047774000@Atlassian.JIRA>
References: <JIRA.13002658.1473047774000@Atlassian.JIRA> <JIRA.13002658.1473047774458@arcas>
Subject: [jira] [Commented] (CARBONDATA-208) User should be able to turn on
 and off the STATISTIC log
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 20 Sep 2016 07:29:26 -0000


    [ https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505873#comment-15505873 ] 

ASF GitHub Bot commented on CARBONDATA-208:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/176#discussion_r79549670
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala ---
    @@ -158,7 +159,16 @@ case class CarbonDictionaryDecoder(
             val carbonTable = relation.carbonRelation.carbonRelation.metaData.carbonTable
             (carbonTable.getFactTableName, carbonTable.getAbsoluteTableIdentifier)
           }.toMap
    -      val recorder = new QueryStatisticsRecorder(queryId)
    +      val queryStatisticsRecorderInstanceType = CarbonProperties.getInstance()
    --- End diff --
    
    same, move it to factory class


> User should be able to turn on and off the STATISTIC log
> --------------------------------------------------------
>
>                 Key: CARBONDATA-208
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-208
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Jacky Li
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Currently there are many STATISTIC log for performance tuning purpose, but it should be configurable by the user.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)