Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E3A12200B84 for ; Tue, 6 Sep 2016 03:41:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E2178160ACC; Tue, 6 Sep 2016 01:41:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 33521160ABC for ; Tue, 6 Sep 2016 03:41:24 +0200 (CEST) Received: (qmail 19425 invoked by uid 500); 6 Sep 2016 01:41:23 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 19416 invoked by uid 99); 6 Sep 2016 01:41:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2016 01:41:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EA8E0C0736 for ; Tue, 6 Sep 2016 01:41:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.539 X-Spam-Level: X-Spam-Status: No, score=-4.539 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.519] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AGArbJkZyeLL for ; Tue, 6 Sep 2016 01:41:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 870B05F3A0 for ; Tue, 6 Sep 2016 01:41:21 +0000 (UTC) Received: (qmail 19402 invoked by uid 99); 6 Sep 2016 01:41:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2016 01:41:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 88F212C014F for ; Tue, 6 Sep 2016 01:41:20 +0000 (UTC) Date: Tue, 6 Sep 2016 01:41:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@carbondata.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CARBONDATA-201) Add comment Option MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 06 Sep 2016 01:41:25 -0000 [ https://issues.apache.org/jira/browse/CARBONDATA-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466122#comment-15466122 ] ASF GitHub Bot commented on CARBONDATA-201: ------------------------------------------- Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/118#discussion_r77563572 --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInputMeta.java --- @@ -162,6 +168,8 @@ private void readData(Node stepnode) throws KettleXMLException { blocksID = XMLHandler.getTagValue(stepnode, "blocksID"); partitionID = XMLHandler.getTagValue(stepnode, "partitionID"); escapeCharacter = XMLHandler.getTagValue(stepnode, "escapeCharacter"); + quoteCharacter = XMLHandler.getTagValue(stepnode, "quoteCharacter"); + commentCharacter = XMLHandler.getTagValue(stepnode, "commentCharacter"); --- End diff -- please keep the same sequence: escapeCharacter -> quoteCharacter -> commentCharacter > Add comment Option > ------------------- > > Key: CARBONDATA-201 > URL: https://issues.apache.org/jira/browse/CARBONDATA-201 > Project: CarbonData > Issue Type: Bug > Reporter: Lionx > > add csv comment option to csv paser, and fix one bug when passing qutochar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)