Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
Date: Thu, 1 Sep 2016 07:46:21 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@carbondata.incubator.apache.org
Message-ID: <JIRA.13001765.1472665681000.466845.1472715981921@Atlassian.JIRA>
In-Reply-To: <JIRA.13001765.1472665681000@Atlassian.JIRA>
References: <JIRA.13001765.1472665681000@Atlassian.JIRA> <JIRA.13001765.1472665681693@arcas>
Subject: [jira] [Commented] (CARBONDATA-198) Implementing system level lock
 for compaction.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 01 Sep 2016 07:46:41 -0000


    [ https://issues.apache.org/jira/browse/CARBONDATA-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454646#comment-15454646 ] 

ASF GitHub Bot commented on CARBONDATA-198:
-------------------------------------------

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/116#discussion_r77127755
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -297,15 +366,144 @@ object CarbonDataRDDFactory extends Logging {
         }
         else {
           logger
    -        .audit("Not able to acquire the compaction lock for table " +
    +        .audit("Not able to acquire the system level compaction lock for table " +
               s"${carbonLoadModel.getDatabaseName}.${carbonLoadModel.getTableName}"
             )
           logger
             .error("Not able to acquire the compaction lock for table " + carbonLoadModel
               .getDatabaseName + "." + carbonLoadModel.getTableName
             )
    -      sys.error("Table is already locked for compaction. Please try after some time.")
    +      if (!CarbonCompactionUtil
    +        .createCompactionRequiredFile(carbonTable.getMetaDataFilepath, compactionType)) {
    --- End diff --
    
    move printing log to  function


> Implementing system level lock for compaction.
> ----------------------------------------------
>
>                 Key: CARBONDATA-198
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-198
>             Project: CarbonData
>          Issue Type: Bug
>          Components: spark-integration
>            Reporter: ravikiran
>
> 1. making DDL of compaction as blocking call.
> 2. implemented System level compaction locking. only one compaction allowed , other requests will create compaction request file. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)