carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-279) [DataLoading]Save a DataFrame to CarbonData file without writing CSV file
Date Wed, 28 Sep 2016 14:31:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529821#comment-15529821
] 

ASF GitHub Bot commented on CARBONDATA-279:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/203#discussion_r80900701
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonOption.scala
---
    @@ -17,13 +17,15 @@
     
     package org.apache.carbondata.spark
     
    +import org.apache.spark.sql.{getDB, SQLContext}
    +
     /**
      * Contains all options for Spark data source
      */
    -class CarbonOption(options: Map[String, String]) {
    +class CarbonOption(options: Map[String, String], cc: SQLContext) {
       def tableIdentifier: String = options.getOrElse("tableName", s"$dbName.$tableName")
     
    -  def dbName: String = options.getOrElse("dbName", "default")
    +  def dbName: String = getDB.getDatabaseName(options.get("dbName"), cc)
    --- End diff --
    
    Is this modification required for this PR?
    It is better not adding cc into CarbonOption which will restrict its usage


> [DataLoading]Save a DataFrame to CarbonData file without writing CSV file
> -------------------------------------------------------------------------
>
>                 Key: CARBONDATA-279
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-279
>             Project: CarbonData
>          Issue Type: Improvement
>    Affects Versions: 0.1.0-incubating
>            Reporter: QiangCai
>            Assignee: QiangCai
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Directly save a DataFrame to CarbonData file without writing CSV file



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message