carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-276) Add trim option
Date Fri, 30 Sep 2016 09:27:21 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535530#comment-15535530
] 

ASF GitHub Bot commented on CARBONDATA-276:
-------------------------------------------

Github user lion-x commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/200#discussion_r81306658
  
    --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java
---
    @@ -465,6 +466,7 @@ private static void generateGraph(IDataProcessStatus schmaModel, SchemaInfo
info
         model.setEscapeCharacter(schmaModel.getEscapeCharacter());
         model.setQuoteCharacter(schmaModel.getQuoteCharacter());
         model.setCommentCharacter(schmaModel.getCommentCharacter());
    +    model.setTrim(schmaModel.getTrim());
    --- End diff --
    
    In some cases, users want to trim some string field in csv, he set in Load DML option,
and we need to handle to in csvinput step. So we the trim should be transformed to CSVinput
step.
    
    For Example, in some usecases, the LeadingWhiteSpace in a String, like " fsdfsd" maybe
meaningful. Users want to keep the LeadingWhiteSpace. So we add this option for users, let
them choose.



> Add trim option
> ---------------
>
>                 Key: CARBONDATA-276
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-276
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Lionx
>            Assignee: Lionx
>            Priority: Minor
>
> Fix a bug and add trim option.
> Bug: When string is contains LeadingWhiteSpace or TrailingWhiteSpace, query result is
null. This is because the dictionary ignore the LeadingWhiteSpace and TrailingWhiteSpace and
the csvInput dose not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message