carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-270) [Filter Optimization] double data type value comparison optimization
Date Fri, 23 Sep 2016 07:22:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515663#comment-15515663
] 

ASF GitHub Bot commented on CARBONDATA-270:
-------------------------------------------

GitHub user sujith71955 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/194

    [CARBONDATA-270] Double data type value comparison optimization

    [Description] Double data type value comparison optimization,EqualsToExpression evaluation
for double values first check for the equality of nan values and then the double value comparison
happens, since nan comparison scenarios are rare we can push the comparison of nan after the
double value comparison.
    
    Already present UT testcases can verify the feature modification impact.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sujith71955/incubator-carbondata master_doubleCmprOptimizations

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #194
    
----
commit f6770ee14f737911071ba94252089587efb3c6d4
Author: sujith71955 <sujithchacko.2010@gmail.com>
Date:   2016-09-23T07:07:12Z

    [Issue Number] CARBONDATA-270]
    [Description] Double data type value comparison optimization,EqualsToExpression evaluation
for double values first check for the equality of nan values and then the double value comparison
happens, since nan comparison scenarios are rare we can push the comparison of nan after the
double value comparison.

----


> [Filter Optimization] double data type value comparison optimization
> --------------------------------------------------------------------
>
>                 Key: CARBONDATA-270
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-270
>             Project: CarbonData
>          Issue Type: Improvement
>          Components: core
>            Reporter: Sujith
>            Assignee: Sujith
>            Priority: Minor
>
> EqualsToExpression evaluation for double values first check for the equality of nan values
and then the double value comparison happens, since nan comparison scenarios are rare we can
push the comparison of nan after the double value comparison.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message