carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-250) Throw exception and fail the data load if provided MAXCOLUMNS value is not proper
Date Sat, 17 Sep 2016 20:52:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499670#comment-15499670
] 

ASF GitHub Bot commented on CARBONDATA-250:
-------------------------------------------

GitHub user sujith71955 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/169

    [CARBONDATA-250] Filter result is not proper when Double data type values with 0.0 and
-0.0 will be used.

    [**Problem**] 
    Equals filter query where -0.0 is used in filter model was not giving proper result since
the system was comparing double value 0.0 and -0.0 as different and resultset was getting
changed. 
    eg: select log(c4_double,1) from Test_Boundary1 where log(c4_double,1)= -0.0
    [**Solution**] 
    System  has to compare double values for its equality and also it will preserve the -0.0
and 0.0 equality as same  == operator ,also preserve NaN equality check as per java.lang.Double.equals()

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sujith71955/incubator-carbondata master_DoubleTypeEquals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #169
    
----
commit 6b7c39ccb73d84cf2d5943e0542077d26c1a5e87
Author: Venkata Ramana G <ramana.gollamudi@huawei.com>
Date:   2016-09-17T16:38:11Z

    [CARBONDATA-250] Filter result is not proper when Double data type values with 0.0 and
-0.0 will be used.
    [Description] This method will compare double values for its equality and also it will
preserve the -0.0 and 0.0 equality as per == ,also preserve NaN equality check as per java.lang.Double.equals()

----


> Throw exception and fail the data load if provided MAXCOLUMNS value is not proper
> ---------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-250
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-250
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Manohar Vanam
>            Assignee: Manohar Vanam
>             Fix For: 0.2.0-incubating
>
>
> If the provided MAXCOLUMNS value in load query is not proper, then throw exception and
fail the data load.
> Impact Area : Load query with maxcolumns option value



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message