carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-233) bad record logger support for non parseable numeric and timestamp data
Date Mon, 12 Sep 2016 04:20:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483012#comment-15483012
] 

ASF GitHub Bot commented on CARBONDATA-233:
-------------------------------------------

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/148#discussion_r78314030
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java
---
    @@ -1133,6 +1149,9 @@ else if(isComplexTypeColumn[j]) {
                           .getDirectDictionaryGenerator(details.getColumnType());
                   surrogateKeyForHrrchy[0] =
                       directDictionaryGenerator1.generateDirectSurrogateKey(tuple);
    +              if (badRecordsLoggerEnable && surrogateKeyForHrrchy[0] == 1) {
    +                surrogateKeyForHrrchy[0] = -1;
    --- End diff --
    
    Replace -1 and 1 with proper identifiers from CarbonCommonConstants to give proper meaning
and improve code readability


> bad record logger support for non parseable numeric and timestamp data
> ----------------------------------------------------------------------
>
>                 Key: CARBONDATA-233
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-233
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Mohammad Shahid Khan
>            Assignee: Mohammad Shahid Khan
>
> bad record logger support for non parseable numeric and timestamp data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message