carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-220) TimeStampDirectDictionaryGenerator_UT.java is not running in the build
Date Thu, 08 Sep 2016 10:14:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473466#comment-15473466
] 

ASF GitHub Bot commented on CARBONDATA-220:
-------------------------------------------

GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/144

    [CARBONDATA-220] TimeStampDirectDictionaryGenerator_UT.java is not running in the build

    # **Why raise this pr?**
    
    Our build script does not execute the test case if the class name does not have Test or
TestCase 
    There was no boundary value test case for the timestamp datatype.
    
    # **How to resolve?**
    
    We have to refactor the class and have to add the boundary test cases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata test_case_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit aa945684cfeb9639248481bce25872f00824cc2b
Author: mohammadshahidkhan <mohdshahidkhan1987@gmail.com>
Date:   2016-09-08T10:06:11Z

    [CARBONDATA-220] TimeStampDirectDictionaryGenerator_UT.java is not running in the build

----


> TimeStampDirectDictionaryGenerator_UT.java is not running in the build
> ----------------------------------------------------------------------
>
>                 Key: CARBONDATA-220
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-220
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Mohammad Shahid Khan
>            Assignee: Mohammad Shahid Khan
>             Fix For: 0.2.0-incubating
>
>
> TimeStampDirectDictionaryGenerator_UT.java is not running in the build.
> And generateDirectSurrogateKey test is failing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message