carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-208) User should be able to turn on and off the STATISTIC log
Date Mon, 26 Sep 2016 05:55:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522151#comment-15522151
] 

ASF GitHub Bot commented on CARBONDATA-208:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/176#discussion_r80411176
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
    @@ -158,7 +158,8 @@ case class CarbonDictionaryDecoder(
             val carbonTable = relation.carbonRelation.carbonRelation.metaData.carbonTable
             (carbonTable.getFactTableName, carbonTable.getAbsoluteTableIdentifier)
           }.toMap
    -      val recorder = new QueryStatisticsRecorder(queryId)
    +
    +      val recorder = CarbonTimeStatisticsFactory.createRecorder(queryId);
    --- End diff --
    
    This should be task/executor side recorder, right? Why not name it createTaskRecorder
or createExecutorRecorder


> User should be able to turn on and off the STATISTIC log
> --------------------------------------------------------
>
>                 Key: CARBONDATA-208
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-208
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Jacky Li
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Currently there are many STATISTIC log for performance tuning purpose, but it should
be configurable by the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message