carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-208) User should be able to turn on and off the STATISTIC log
Date Sun, 25 Sep 2016 05:24:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15520224#comment-15520224
] 

ASF GitHub Bot commented on CARBONDATA-208:
-------------------------------------------

Github user Zhangshunyu commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/176#discussion_r80374297
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java
---
    @@ -17,47 +17,51 @@
     
     package org.apache.carbondata.core.util;
     
    -import org.apache.carbondata.core.carbon.querystatistics.DriverQueryStatisticsRecorder;
    +import org.apache.carbondata.core.carbon.querystatistics.*;
     import org.apache.carbondata.core.constants.CarbonCommonConstants;
     
     public class CarbonTimeStatisticsFactory {
       private static String LoadStatisticsInstanceType;
    -  private static LoadStatistics LoadStatisticsInstance;
    --- End diff --
    
    dont modify here,so that load instsnce can just judge once,if you modify here,it
would judge many times.
    so, pls set it back.


> User should be able to turn on and off the STATISTIC log
> --------------------------------------------------------
>
>                 Key: CARBONDATA-208
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-208
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Jacky Li
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Currently there are many STATISTIC log for performance tuning purpose, but it should
be configurable by the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message