carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-208) User should be able to turn on and off the STATISTIC log
Date Tue, 20 Sep 2016 07:29:21 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505871#comment-15505871
] 

ASF GitHub Bot commented on CARBONDATA-208:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/176#discussion_r79549321
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java
---
    @@ -52,11 +58,18 @@ public static LoadStatistics getLoadStatisticsInstance() {
         return LoadStatisticsInstance;
       }
     
    -  private static DriverQueryStatisticsRecorder genQueryStatisticsRecorderInstance() {
    -    return DriverQueryStatisticsRecorder.getInstance();
    +  private static QueryStatisticsRecorder genQueryStatisticsRecorderInstance() {
    +    switch (queryStatisticsRecorderInstanceType.toLowerCase()) {
    --- End diff --
    
    change to if else statement, then no need for default branch


> User should be able to turn on and off the STATISTIC log
> --------------------------------------------------------
>
>                 Key: CARBONDATA-208
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-208
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Jacky Li
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Currently there are many STATISTIC log for performance tuning purpose, but it should
be configurable by the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message