carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-201) Add comment Option
Date Tue, 06 Sep 2016 01:41:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466122#comment-15466122
] 

ASF GitHub Bot commented on CARBONDATA-201:
-------------------------------------------

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/118#discussion_r77563572
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInputMeta.java
---
    @@ -162,6 +168,8 @@ private void readData(Node stepnode) throws KettleXMLException {
           blocksID = XMLHandler.getTagValue(stepnode, "blocksID");
           partitionID = XMLHandler.getTagValue(stepnode, "partitionID");
           escapeCharacter = XMLHandler.getTagValue(stepnode, "escapeCharacter");
    +      quoteCharacter = XMLHandler.getTagValue(stepnode, "quoteCharacter");
    +      commentCharacter = XMLHandler.getTagValue(stepnode, "commentCharacter");
    --- End diff --
    
    please keep the same sequence:  escapeCharacter -> quoteCharacter -> commentCharacter



> Add comment Option 
> -------------------
>
>                 Key: CARBONDATA-201
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-201
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Lionx
>
> add csv comment option to csv paser, and fix one bug when passing qutochar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message