carbondata-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [carbondata] akashrn5 commented on a change in pull request #4148: [CARBONDATA-4242]Improve cdc performance and introduce new APIs for UPSERT, DELETE, INSERT and UPDATE
Date Thu, 15 Jul 2021 17:56:30 GMT

akashrn5 commented on a change in pull request #4148:
URL: https://github.com/apache/carbondata/pull/4148#discussion_r670689780



##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java
##########
@@ -168,7 +175,7 @@ public void setColumnSchema(List<ColumnSchema> columnSchema) {
    * @throws IOException
    */
   public void serializeData(DataOutput out, Map<String, Short> uniqueLocation, boolean
isCountJob,
-      boolean isExternalPath)
+      boolean isExternalPath, CdcVO cdcVO)

Review comment:
       done

##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockIndex.java
##########
@@ -886,7 +886,7 @@ public String getTableTaskInfo(int index) {
     }
   }
 
-  private byte[][] getMinMaxValue(IndexRow row, int index) {
+  public static byte[][] getMinMaxValue(IndexRow row, int index) {

Review comment:
       done

##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockIndex.java
##########
@@ -895,7 +895,7 @@ public String getTableTaskInfo(int index) {
     return minMax;
   }
 
-  private boolean[] getMinMaxFlag(IndexRow row, int index) {
+  public static boolean[] getMinMaxFlag(IndexRow row, int index) {

Review comment:
       removed this change, as it was not required




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message