From commits-return-7946-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org Thu Jan 4 07:00:31 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id ECE89180657 for ; Thu, 4 Jan 2018 07:00:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DC9DC160C3A; Thu, 4 Jan 2018 06:00:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2EB66160C39 for ; Thu, 4 Jan 2018 07:00:31 +0100 (CET) Received: (qmail 15698 invoked by uid 500); 4 Jan 2018 06:00:30 -0000 Mailing-List: contact commits-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list commits@carbondata.apache.org Received: (qmail 15687 invoked by uid 99); 4 Jan 2018 06:00:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2018 06:00:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 42EB4DFC27; Thu, 4 Jan 2018 06:00:30 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: manishgupta88@apache.org To: commits@carbondata.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: carbondata git commit: [CARBONDATA-1975] Wrong input metrics displayed for carbon Date: Thu, 4 Jan 2018 06:00:30 +0000 (UTC) Repository: carbondata Updated Branches: refs/heads/master 910d496cf -> 0b0473c5f [CARBONDATA-1975] Wrong input metrics displayed for carbon Modified code to correct the number of records as input metrics in the spark UI This closes #1754 Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/0b0473c5 Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/0b0473c5 Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/0b0473c5 Branch: refs/heads/master Commit: 0b0473c5f15fd7ff92fe7a2b42399817e534f349 Parents: 910d496 Author: dhatchayani Authored: Wed Jan 3 19:12:18 2018 +0530 Committer: manishgupta88 Committed: Thu Jan 4 11:33:39 2018 +0530 ---------------------------------------------------------------------- .../scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala | 1 - .../src/main/scala/org/apache/spark/CarbonInputMetrics.scala | 6 +----- 2 files changed, 1 insertion(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/carbondata/blob/0b0473c5/integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---------------------------------------------------------------------- diff --git a/integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala b/integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala index 09dbd71..cc68b9c 100644 --- a/integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala +++ b/integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala @@ -379,7 +379,6 @@ class CarbonScanRDD( } havePair = false val value = reader.getCurrentValue - inputMetricsStats.updateByValue(value) value } http://git-wip-us.apache.org/repos/asf/carbondata/blob/0b0473c5/integration/spark2/src/main/scala/org/apache/spark/CarbonInputMetrics.scala ---------------------------------------------------------------------- diff --git a/integration/spark2/src/main/scala/org/apache/spark/CarbonInputMetrics.scala b/integration/spark2/src/main/scala/org/apache/spark/CarbonInputMetrics.scala index deef157..6f038eb 100644 --- a/integration/spark2/src/main/scala/org/apache/spark/CarbonInputMetrics.scala +++ b/integration/spark2/src/main/scala/org/apache/spark/CarbonInputMetrics.scala @@ -78,10 +78,6 @@ class CarbonInputMetrics extends InitInputMetrics{ } override def updateByValue(value: Object): Unit = { - value match { - case batch: ColumnarBatch => - inputMetrics.incRecordsRead(batch.numRows()) - case _ => - } + } }