carbondata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvram...@apache.org
Subject [1/2] incubator-carbondata git commit: Problem:Column heading was missing in driver statistics table and scan block time was always zero in query statistics table.
Date Sat, 17 Sep 2016 21:51:26 GMT
Repository: incubator-carbondata
Updated Branches:
  refs/heads/master 17f602dec -> 159aae9d3


Problem:Column heading was missing in driver statistics table and scan block time was always
zero in query statistics table.

Analysis:While creating driver statistics table header was not created and the scan block
time was not initialized before recording in statistics recorder.

Fix:One more line is added to print the column header in driver statistics table and the scan
block time is initialized before recording the statistics.

Impact:Logs of all query


Project: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/commit/070fb409
Tree: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/tree/070fb409
Diff: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/diff/070fb409

Branch: refs/heads/master
Commit: 070fb409e780cae70de4beeb60e2ab95de24485b
Parents: 17f602d
Author: akashrn5 <akash.r.nilugal@huawei.com>
Authored: Sat Sep 17 12:33:31 2016 +0530
Committer: Venkata Ramana G <ramana.gollamudi@huawei.com>
Committed: Sun Sep 18 03:17:59 2016 +0530

----------------------------------------------------------------------
 .../carbon/querystatistics/DriverQueryStatisticsRecorder.java   | 5 +++--
 .../scan/result/iterator/AbstractDetailQueryResultIterator.java | 4 +++-
 2 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/070fb409/core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/DriverQueryStatisticsRecorder.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/DriverQueryStatisticsRecorder.java
b/core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/DriverQueryStatisticsRecorder.java
index c756b39..0b5af6c 100644
--- a/core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/DriverQueryStatisticsRecorder.java
+++ b/core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/DriverQueryStatisticsRecorder.java
@@ -155,7 +155,7 @@ public class DriverQueryStatisticsRecorder {
       int len1 = 8;
       int len2 = 20;
       int len3 = 21;
-      int len4 = 22;
+      int len4 = 24;
       String line = "+" + printLine("-", len1) + "+" + printLine("-", len2) + "+" +
           printLine("-", len3) + "+" + printLine("-", len4) + "+";
       String line2 = "|" + printLine(" ", len1) + "+" + printLine("-", len2) + "+" +
@@ -164,7 +164,8 @@ public class DriverQueryStatisticsRecorder {
       tableInfo.append(line).append("\n");
       tableInfo.append("|" + printLine(" ", (len1 - "Module".length())) + "Module" + "|"
+
           printLine(" ", (len2 - "Operation Step".length())) + "Operation Step" + "|" +
-          printLine(" ", (len3 + len4 + 1 - "Query Cost".length())) + "Query Cost" + "|"
+ "\n");
+          printLine(" ", (len3 - "Total Query Cost".length())) + "Total Query Cost" + "|"
+
+          printLine(" ", (len4 - "Query Cost".length())) + "Query Cost" + "|" + "\n");
       tableInfo.append(line).append("\n");
       // print sql_parse_t,load_meta_t,block_allocation_t,block_identification_t
       if (!StringUtils.isEmpty(sql_parse_time) &&

http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/070fb409/core/src/main/java/org/apache/carbondata/scan/result/iterator/AbstractDetailQueryResultIterator.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/scan/result/iterator/AbstractDetailQueryResultIterator.java
b/core/src/main/java/org/apache/carbondata/scan/result/iterator/AbstractDetailQueryResultIterator.java
index 36c4ad0..02505e8 100644
--- a/core/src/main/java/org/apache/carbondata/scan/result/iterator/AbstractDetailQueryResultIterator.java
+++ b/core/src/main/java/org/apache/carbondata/scan/result/iterator/AbstractDetailQueryResultIterator.java
@@ -106,6 +106,7 @@ public abstract class AbstractDetailQueryResultIterator extends CarbonIterator
{
   }
 
   private void intialiseInfos() {
+    totalScanTime=System.currentTimeMillis();
     for (BlockExecutionInfo blockInfo : blockExecutionInfos) {
       DataRefNodeFinder finder = new BTreeDataRefNodeFinder(blockInfo.getEachColumnValueSize());
       DataRefNode startDataBlock = finder
@@ -134,7 +135,8 @@ public abstract class AbstractDetailQueryResultIterator extends CarbonIterator
{
     } else {
       if (!isStatisticsRecorded) {
         QueryStatistic statistic = new QueryStatistic();
-        statistic.addFixedTimeStatistic(QueryStatisticsConstants.SCAN_BLOCKS_TIME, totalScanTime);
+        statistic.addFixedTimeStatistic(QueryStatisticsConstants.SCAN_BLOCKS_TIME,
+            System.currentTimeMillis() - totalScanTime);
         recorder.recordStatistics(statistic);
         isStatisticsRecorded = true;
       }


Mime
View raw message