camel-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Preben.Asmussen" <p...@dr.dk>
Subject Re: spring.activemq.broker-url not set correct on Activemq + Spring Boot
Date Fri, 26 May 2017 16:38:26 GMT
Hi Claus

The example is now head, and I just wanted to follow up on this in regards
to https://issues.apache.org/jira/browse/CAMEL-10226 where the change to the
ActivemqComponent was introduced.

IMHO if you are using SB starters you would expect the activemq autowirering
to work how it's described on  
https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-messaging.html#boot-features-activemq

If you want to override cf autowirering with eg. a xml configuration it
seems that all configuration should be present in the xml eg. ->

 <bean primary="true" id="jmsConnectionFactory"
class="org.apache.activemq.ActiveMQConnectionFactory">
    <property name="brokerURL" value="tcp://localhost:1234" />
  </bean>

  <bean id="pooledConnectionFactory"
class="org.apache.activemq.pool.PooledConnectionFactory"
    init-method="start" destroy-method="stop">
    <property name="maxConnections" value="8" />
    <property name="connectionFactory" ref="jmsConnectionFactory" />
  </bean>

  <bean id="jmsConfig"
class="org.apache.camel.component.jms.JmsConfiguration">
    
    <property name="connectionFactory" ref="pooledConnectionFactory" />
    <property name="concurrentConsumers" value="10" />
  </bean>

  <bean id="activemq"
class="org.apache.activemq.camel.component.ActiveMQComponent">
    <property name="configuration" ref="jmsConfig" />
  </bean>

And then have a SB configuration bean like

@Component
@Configuration
@ImportResource(locations = "classpath:amq.xml")
public class SampleAutowiredAmqRoute extends RouteBuilder {
 .....
}

IMHO I think the commit
https://github.com/apache/activemq/commit/4437393aa1a981a182142c255f76ae7cc50af183#diff-474de9fc51b7273d42a39c6327492388
should be reverted, or do you see a better solution ?

/preben



--
View this message in context: http://camel.465427.n5.nabble.com/spring-activemq-broker-url-not-set-correct-on-Activemq-Spring-Boot-tp5799927p5800849.html
Sent from the Camel - Users mailing list archive at Nabble.com.

Mime
View raw message