Mailing-List: contact users-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@camel.apache.org
MIME-Version: 1.0
In-Reply-To: <CA+D-ZCSr4VYH6z27DYfWDi_vUBi3F_mmGhEh2wpkJm=P=KD0jQ@mail.gmail.com>
References: <CA+D-ZCSXWCuQsjYPfdG9oELezUQxQ3n6eay5BZ+UDvM3Tp3=iw@mail.gmail.com>
 <CAGB5yNkvRDfGzAUQ=SP9tZe4vTfhWVNC_dD6SPvtNrHkFumqkg@mail.gmail.com>
 <8e5ea789-606e-05df-0557-7e5ce082e508@gmail.com> <CAGB5yN=3dLdO2UNGNtpLWRUk-J=STtF-2049M1kyhLxN-bGQGw@mail.gmail.com>
 <CA+D-ZCSr4VYH6z27DYfWDi_vUBi3F_mmGhEh2wpkJm=P=KD0jQ@mail.gmail.com>
From: Jonathan Schoreels <jonathan.schoreels@gmail.com>
Date: Sun, 23 Apr 2017 16:14:23 +0200
Message-ID: <CA+D-ZCS5svwTikhUFPrSKX=Nxu=sxgud1i4dBa6kiHDi49ccug@mail.gmail.com>
Subject: Re: JdbcAggregationRepository doesn't preserve properties :
 Feature/Bug ?
To: users@camel.apache.org
Content-Type: multipart/alternative; boundary=001a1149d4f8854e80054dd61b96
archived-at: Sun, 23 Apr 2017 14:14:34 -0000

--001a1149d4f8854e80054dd61b96
Content-Type: text/plain; charset=UTF-8

(The pull request has been made : https://github.com/apache/camel/pull/1654)

Jonathan

2017-04-23 16:13 GMT+02:00 Jonathan Schoreels <jonathan.schoreels@gmail.com>
:

> Hi Claus,
>
> Thank you for the reminder, I had some other test with the repository and
> found it another feature that seems to be normal : if the deadletter route
> throws an exception, it will be send again to DLQ again, and again. I say
> it's normal since a test seems to cover it :
> JdbcAggregateRecoverDeadLetterChannelFailedTest.
>
> I however did not find if it's a behaviour that should be implemented in
> ALL RecoverableAggregationRepository or only some of them. I've just
> added javadoc for the JDBC's one, in doubt.
>
> Jonathan
>
> 2017-04-23 10:04 GMT+02:00 Claus Ibsen <claus.ibsen@gmail.com>:
>
>> Hi Jonathan
>>
>> Did you get a chance to do this? Its good to help the project if users
>> can get involved and provide fixes/improvments. And a small javadoc
>> contribution is a great place to start.
>>
>> On Wed, Apr 12, 2017 at 1:34 PM, Jonathan Schoreels
>> <jonathan.schoreels@gmail.com> wrote:
>> > Is it allowed to open pull request just to add java doc, or would you
>> prefer
>> > to do it yourself ?
>> >
>> >
>> > On 2017-04-12 13:31, Claus Ibsen wrote:
>> >>
>> >> Yes only body + headers is stored that is by design
>> >>
>> >> On Wed, Apr 12, 2017 at 1:19 PM, Jonathan Schoreels
>> >> <jonathan.schoreels@gmail.com> wrote:
>> >>>
>> >>> Hello,
>> >>>
>> >>> I've been using JdbcAggregationRepository recently and discovered
>> that it
>> >>> won't save the property in the table and thus, losing them at each
>> >>> aggregation step.
>> >>>
>> >>> I know property are meant to be inner-route variable, and headers
>> >>> metadata
>> >>> for protocol/outer-scope, and that by definition, a
>> >>> JdbcAggregationRepository is an outer service. However, at the same
>> time,
>> >>> it's an abstraction inside the route, and it's still very unsetting to
>> >>> have
>> >>> property that dissapear in the same camel route.
>> >>>
>> >>> Do you see it as a Bug or a Feature ?
>> >>>
>> >>> PS : I'm still asking myself why there is no user guide to use
>> >>> JdbcAggregationRepository in the book (Hawt example) or a
>> "pretty-doc" in
>> >>> http://camel.apache.org/aggregator.html. Or maybe there is other more
>> >>> standard way to aggregate in a persistent repository that I don't know
>> >>> yet ?
>> >>>
>> >>> Thank you,
>> >>>
>> >>> Jonathan Schoreels
>> >>
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2
>>
>
>

--001a1149d4f8854e80054dd61b96--