camel-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: camel-core not detecting converters on bundle restart in karaf4
Date Thu, 22 Dec 2016 11:09:41 GMT
The unload of type converter was not the right path.

Can you put a small example together that demonstrates this problem
and put up on github or attach as .zip to the JIRA ticket. And make it
so it uses Karaf 4.0.8 and Camel 2.18.1 as we want to use latest
release.

On Thu, Dec 22, 2016 at 11:33 AM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
> I logged a ticket
> https://issues.apache.org/jira/browse/CAMEL-10641
>
> However as this is OSGi then its always tricky
>
> On Thu, Dec 22, 2016 at 10:51 AM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>> Hi
>>
>> Yeah I think maybe the Activator in camel-core should upon
>> removeBundle (or maybe even in modifiedBundle if refresh only calls
>> that).
>> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/impl/osgi/Activator.java#L165
>>
>> There is some logic that registers and scans type converters, but the
>> code does not remove those type converters.
>> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/impl/osgi/Activator.java#L225
>>
>> This logic is invoked in the register method
>> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/impl/osgi/Activator.java#L384
>>
>> But the unregister methods is not implemented where it should
>> potentially unregister those type converters it added.
>> Which means the loader should keep state of which type converters it
>> found, so it knows which ones to remove.
>>
>>
>>
>> On Tue, Dec 20, 2016 at 2:36 PM, yogu13 <yogu13@gmail.com> wrote:
>>> Is this a defect should i raise a JIRA ?
>>>
>>>
>>> Regards,
>>> -Yogesh
>>>
>>>
>>>
>>> --
>>> View this message in context: http://camel.465427.n5.nabble.com/camel-core-not-detecting-converters-on-bundle-restart-in-karaf4-tp5791503p5791744.html
>>> Sent from the Camel - Users mailing list archive at Nabble.com.
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2
>
>
>
> --
> Claus Ibsen
> -----------------
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2



-- 
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

Mime
View raw message