Mailing-List: contact users-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@camel.apache.org
Received-SPF: pass (nike.apache.org: domain of claus.ibsen@gmail.com
 designates 209.85.223.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAGB5yNkvWLECLfiKjOTSip3aicjt49jmWRmdPVHTt0jHpKdTsA@mail.gmail.com>
References: <1417440312542-5759864.post@n5.nabble.com>
 <CAGB5yNkvWLECLfiKjOTSip3aicjt49jmWRmdPVHTt0jHpKdTsA@mail.gmail.com>
From: Claus Ibsen <claus.ibsen@gmail.com>
Date: Tue, 2 Dec 2014 13:16:13 +0100
Message-ID: 
 <CAGB5yNkP9mWjbBLPagmwp=t0eg1CKrG5uBsZr09YgrQD-_RN7Q@mail.gmail.com>
Subject: Re: Rest DSL - OutType in case of error message problem
To: "users@camel.apache.org" <users@camel.apache.org>
Content-Type: text/plain; charset=UTF-8

Hi

I logged, and fixed this for next release
https://issues.apache.org/jira/browse/CAMEL-8104

On Tue, Dec 2, 2014 at 11:38 AM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
> Hi
>
> Yeah well spotted. We should improve rest-dsl to support these
> use-cases where you prepare a response message yourself and set the
> http status code to some error code etc.
>
> I guess if the status code is >= 300+ then we should assume its an
> error, and use the message body as-is as the response.
>
> On Mon, Dec 1, 2014 at 2:25 PM, panzerhans <espen+camel@tjonneland.no> wrote:
>> I have a setup with Swagger and the Rest DSL. Swagger uses the
>> OutType(MyType.class) to annotate the API with the return type. However,
>> there are times when I wish to return something else to the caller, e.g. an
>> error message with a HTTP response code.
>>
>> Take the following Route as an example:
>>
>> RestDefinition privateAPI =
>> rest(ServiceConstants.PRIVATE_API_VERSION_1).description("Private (internal)
>> REST services for MyServices.");
>>
>> privateAPI.get("/fetchsomething").description("Lists stuff from some
>> service")
>>             .outTypeList(MyPojoForSomething.class)
>>             .route().routeId("A descriptive ID")
>>             .choice()
>>
>> .when(header(ServiceConstants.REQUEST_VALIDATED).isEqualTo("TRUE"))
>>                    .bean(GoAheadAndFillAMyPojoForSomething-into-body.class)
>>                 .otherwise().bean(ErrorMessageConstructor.class);
>>
>> -------
>>
>> * An Interceptor validates the incoming message and sets the Header constant
>> to TRUE or FALSE.
>> * The ErrorMessageConstructor constructs a proper message and puts it as a
>> String into the body together with a correct HTTP code (E.g. Not-Found).
>>
>> Problem: The marshaller, uses outTypeList to determine the way to convert
>> the Message body to Json. If in the above example, the request was "FALSE",
>> the marshaller (I am using Jackson) tries to marshall a String to a
>> MyPojoForSomething.class.
>>
>> The content of the String I have constructed for the error is in this case:
>> "Missing properties in HTTP Header."
>>
>> This results in an error:
>> com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'Missing':
>> was expecting ('true', 'false' or 'null')
>>  at [Source: java.io.ByteArrayInputStream@67618968; line: 1, column: 9]
>>         at
>> com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1419)
>>         ........
>>
>>
>>
>> --
>> View this message in context: http://camel.465427.n5.nabble.com/Rest-DSL-OutType-in-case-of-error-message-problem-tp5759864.html
>> Sent from the Camel - Users mailing list archive at Nabble.com.
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> Email: cibsen@redhat.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
> hawtio: http://hawt.io/
> fabric8: http://fabric8.io/


-- 
Claus Ibsen
-----------------
Red Hat, Inc.
Email: cibsen@redhat.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
hawtio: http://hawt.io/
fabric8: http://fabric8.io/