Mailing-List: contact users-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@camel.apache.org
Received-SPF: pass (nike.apache.org: domain of willem.jiang@gmail.com
 designates 209.85.192.174 as permitted sender)
Date: Fri, 4 Jul 2014 11:29:13 +0800
From: Willem Jiang <willem.jiang@gmail.com>
To: users@camel.apache.org
Message-ID: <etPan.53b61f8c.327b23c6.12b@dhcp-17-73.nay.redhat.com>
In-Reply-To: <etPan.53b5661a.3d1b58ba.109@localhost>
References: <1404387768672-5753283.post@n5.nabble.com>
 <etPan.53b5661a.3d1b58ba.109@localhost>
Subject: Re: Attachments are Lost using Bean Language
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

After did some patch work, I have to take my world back. I don=E2=80=99t =
think we need to copy the attachment back in the InvokeProcessor.

=46or BeanExpression, we are not supposed to modify the exchange or the m=
essage in the evaluation processor, camel just want to know the result of=
 the evaluation.

If you want to change the message attachment header, you can use bean pro=
cess to do that kind of job. I just commit an unit test=5B1=5D to show ho=
w to set the attachment in the bean processor.

=5B1=5Dhttp://git-wip-us.apache.org/repos/asf/camel/commit/a749cefe=C2=A0=

-- =20
Willem Jiang

Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang =20
Weibo: =E5=A7=9C=E5=AE=81willem


On July 3, 2014 at 10:18:08 PM, Willem Jiang (willem.jiang=40gmail.com) w=
rote:
> Yeah, we need to copy the attachments back.
> I just filled a JIRA=5B1=5D for it.
> =20
> =5B1=5Dhttps://issues.apache.org/jira/browse/CAMEL-7575
> =20
> --
> Willem Jiang
> =20
> Red Hat, Inc.
> Web: http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (English)
> http://jnn.iteye.com (Chinese)
> Twitter: willemjiang
> Weibo: =E5=A7=9C=E5=AE=81willem
> =20
> =20
> =20
> On July 3, 2014 at 8:00:24 PM, sabri.bousselmi (infosabri=40yahoo.fr) w=
rote:
> > I think there is a serious issue when evaluatiog Bean language expres=
sion. it
> > seems like attachments are not copied from the resulting exchage.
> > very simple case: invoke a methode where you add an attachment to the=

> > exchange, when the evaluation is ending the value of the exchange wil=
l be
> > null.
> > I debuged in camel source code, the method process Line n:174 did not=
 copie
> > the attachment, below the source code:
> > -------------------------------
> > // copy the original exchange to avoid side effects on it
> > Exchange resultExchange =3D exchange.copy();
> > // remove any existing exception in case we do OGNL on the
> > exception
> > resultExchange.setException(null);
> >
> > // force to use InOut to retrieve the result on the OUT
> > message
> > resultExchange.setPattern(ExchangePattern.InOut);
> > processor.process(resultExchange);
> > result =3D resultExchange.getOut().getBody();
> >
> > // propagate properties and headers from result
> > if (resultExchange.hasProperties()) =7B
> >
> > exchange.getProperties().putAll(resultExchange.getProperties());
> > =7D
> > if (resultExchange.getOut().hasHeaders()) =7B
> >
> > exchange.getIn().getHeaders().putAll(resultExchange.getOut().getHeade=
rs()); =20
> > =7D
> >
> > // propagate exceptions
> > if (resultExchange.getException() =21=3D null) =7B
> > exchange.setException(resultExchange.getException());
> > =7D
> > ---------------------------------------------------------------------=
---- =20
> > can you please approve the issue.
> >
> >
> >
> > --
> > View this message in context: http://camel.465427.n5.nabble.com/Attac=
hments-are-Lost-using-Bean-Language-tp5753283.html =20
> > Sent from the Camel - Users mailing list archive at Nabble.com.
> >
> =20
> =20