camel-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yirco <>
Subject Re: CXF component attachment support for POJO not implemented as specified
Date Sat, 08 Feb 2014 15:19:06 GMT
Hi Willem,

thank you.

I have two comments:

1) It is used in three methods, one for producer and two for consumer. I
believe it should be changed in all the methods so that it works in both

/populateExchangeFromCxfResponse(Exchange camelExchange,
            org.apache.cxf.message.Exchange cxfExchange, 
            Map<String, Object> responseContext)
populateExchangeFromCxfRequest(org.apache.cxf.message.Exchange cxfExchange,
            Exchange camelExchange)
populateCxfResponseFromExchange(Exchange camelExchange, 
            org.apache.cxf.message.Exchange cxfExchange)/

2) Are you sure that this condition is correct?

If it is POJO and XOP then the whole condition shall be false.
!(true && !true) -> !(true && false) -> !(false) -> true

/ boolean isXop =
 // propagate attachments if the data format is not POJO with MTOM enabled
 if (cxfMessage.getAttachments() != null &&
!(DataFormat.POJO.equals(dataFormat) && !isXop)) {
// propagate attachments

View this message in context:
Sent from the Camel - Users mailing list archive at

View raw message