camel-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: [Bindy] Having trouble with the "required" field
Date Mon, 16 Apr 2012 13:36:06 GMT
Hi

Do you mind open a new ticket.
And then attach your modified unit test.

Then we can apply the patch from CAMEL-5018 and add your unit  test.



2012/4/16 Magnus Palmér <magnus.palmer.work@gmail.com>:
> Hmm, I had trouble with creating and applying patches, guess I have to
> update my knowledge there of how to apply patches correctly.
> Anyway, I merge this from trunk to my local 2.9.x branch instead:
>
> Revision: 1292164
> Author: ningjiang
> Date: den 22 februari 2012 08:49:40
> Message:
> CAMEL-5018 support the set the default value on the field of bindy CVS
> ----
> Modified :
> /camel/trunk/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java
> Modified :
> /camel/trunk/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/annotation/DataField.java
> Modified :
> /camel/trunk/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvUnmarshallTest.java
> Modified :
> /camel/trunk/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/model/simple/oneclass/Order.java
>
> After that the merge my test run successfully. ( I had updated the tab test
> case earlier, didn't get Aidas tests to compile on first two tries so I
> used my own test case that I used when trying out this bug in 2.10).
> (I first ran it before merge and it failed as expected.)
>
> Not sure how to proceed from here.
> There is the Jira ticket that I opened earlier that Willem later set to
> resolved since it is resolved in 2.10 (but not 2.9.x).
>
>
> Den 16 april 2012 09:11 skrev Claus Ibsen <claus.ibsen@gmail.com>:
>
>> Hi
>>
>> I got side tracked by more important stuff I needed to attend.
>> And well the Camel project has many committers to help also.
>>
>> Do you mind if you got spare time, to try the 2.9 branch and apply the
>> patch(es) from CAMEL-5018.
>> And try out the use-case from Aida to see if it fixes that?
>>
>> And it would be nice if a JIRA ticket was created. Then we can track this.
>>
>> 2012/4/16 Magnus Palmér <magnus.palmer.work@gmail.com>:
>> > According to Willem Jiang it is CAMEL-5018 that fixes this and when I
>> check
>> > the 2.9.x branch that change doesn't seem to be in there.
>> >
>> > Den 11 april 2012 12:22 skrev Aida <ai.desu@gmail.com>:
>> >
>> >>
>> http://camel.465427.n5.nabble.com/file/n5632391/bindyTest.zipbindyTest.zip
>> >>
>> >> Here I attach my JUnit test and the BindyClass I'm using (is the same I
>> >> only
>> >> changed the name of the fields). The test case that fails is the last
>> one
>> >> (is commented). I hope this to be enought (all this is in the context
>> of a
>> >> bigger project and I can´t attach the full project).
>> >>
>> >> --
>> >> View this message in context:
>> >>
>> http://camel.465427.n5.nabble.com/Bindy-Having-trouble-with-the-required-field-tp5597196p5632391.html
>> >> Sent from the Camel - Users mailing list archive at Nabble.com.
>> >>
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> CamelOne 2012 Conference, May 15-16, 2012: http://camelone.com
>> FuseSource
>> Email: cibsen@fusesource.com
>> Web: http://fusesource.com
>> Twitter: davsclaus, fusenews
>> Blog: http://davsclaus.blogspot.com/
>> Author of Camel in Action: http://www.manning.com/ibsen/
>>



-- 
Claus Ibsen
-----------------
CamelOne 2012 Conference, May 15-16, 2012: http://camelone.com
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/

Mime
View raw message