Mailing-List: contact users-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@camel.apache.org
Received-SPF: pass (nike.apache.org: domain of gary.tully@gmail.com designates
 209.85.216.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1310643345087-4586327.post@n5.nabble.com>
References: <1310462830160-4578300.post@n5.nabble.com>
	<1310517331681-4581082.post@n5.nabble.com>
	<1310559975558-4582476.post@n5.nabble.com>
	<CAGB5yNmAxPXRS86PzU9a3CdsCsD8TbQ_WH3+4CkwTbYg09wQLg@mail.gmail.com>
	<1310643345087-4586327.post@n5.nabble.com>
Date: Thu, 14 Jul 2011 14:47:38 +0100
Message-ID: 
 <CAH+vQmNBbFzR5m8LbShg5wiQAm5O0gZQDn2RTy2AvAbHSOM-Xw@mail.gmail.com>
Subject: Re: Problem with ActiveMQ to Weblogic route
From: Gary Tully <gary.tully@gmail.com>
To: users@camel.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

It makes sense to fix it up such that it can work in your case and I
guess to future proof it a bit.
The solution may be to make it configurable or plugable, adding a
fallback transformer implementation that can be delegated to in this
case.

I imagine a new public static
ActiveMQDestination.setFallbackTransformer() with something that
implements
  public ActiveMQDestination transform(Destination dest) throws JMSExceptio=
n

Can you raise a jira issue against activemq to track this?

On 14 July 2011 12:35, pwanner <pwanner@pwanner.com> wrote:
> Yes this class is part of activemq-core-5.5.0.jar.
>
> I did a modification that works correctly reflecting the Destination
> parameter to check if in the case of weblogic.jms.common.DestinationImpl =
is
> has the isQueue and isTopic methods that could help to determine between
> Queue and Topic.
>
> As the problem is closely related to a Weblogic implementation class, I'm
> not sure that ActiveMQ would like to embed it in its distribution, even t=
hat
> using reflection avoid having a dependency to the Weblogic jar.
>
>
> The modification is in bold below:
>
> =A0 =A0public static ActiveMQDestination transform(Destination dest) thro=
ws
> JMSException {
> =A0 =A0 =A0 =A0if (dest =3D=3D null) {
> =A0 =A0 =A0 =A0 =A0 =A0return null;
> =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0if (dest instanceof ActiveMQDestination) {
> =A0 =A0 =A0 =A0 =A0 =A0return (ActiveMQDestination)dest;
> =A0 =A0 =A0 =A0}
>
> =A0 =A0 =A0 =A0if (dest instanceof Queue && dest instanceof Topic) {
> =A0 =A0 =A0 =A0 =A0 =A0String queueName =3D ((Queue) dest).getQueueName()=
;
> =A0 =A0 =A0 =A0 =A0 =A0String topicName =3D ((Topic) dest).getTopicName()=
;
>
> =A0 =A0 =A0 =A0 =A0 =A0if (queueName !=3D null && topicName =3D=3D null) =
{
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return new ActiveMQQueue(queueName);
> =A0 =A0 =A0 =A0 =A0 =A0} else if (queueName =3D=3D null && topicName !=3D=
 null) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return new ActiveMQTopic(topicName);
> =A0 =A0 =A0 =A0 =A0 =A0}
>
> *
> =A0 =A0 =A0 =A0 =A0 =A0Method isQueueMethod =3D null;
> =A0 =A0 =A0 =A0 =A0 =A0Method isTopicMethod =3D null;
> =A0 =A0 =A0 =A0 =A0 =A0try {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0isQueueMethod =3D dest.getClass().getMetho=
d("isQueue");
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0isTopicMethod =3D dest.getClass().getMetho=
d("isTopic");
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Boolean isQueue =3D (Boolean)isQueueMethod=
.invoke(dest);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Boolean isTopic =3D (Boolean)isTopicMethod=
.invoke(dest);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if(isQueue) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return new ActiveMQQueue(queueName=
);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} else if(isTopic){
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return new ActiveMQTopic(topicName=
);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0 =A0 =A0} catch (Exception e) {}
> *
> =A0 =A0 =A0 =A0 =A0throw new JMSException("Could no disambiguate on queue=
|Topic-name
> totransform pollymorphic destination into a ActiveMQ destination: " + des=
t);
> =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0if (dest instanceof TemporaryQueue) {
> =A0 =A0 =A0 =A0 =A0 =A0return new
> ActiveMQTempQueue(((TemporaryQueue)dest).getQueueName());
> =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0if (dest instanceof TemporaryTopic) {
> =A0 =A0 =A0 =A0 =A0 =A0return new
> ActiveMQTempTopic(((TemporaryTopic)dest).getTopicName());
> =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0if (dest instanceof Queue) {
> =A0 =A0 =A0 =A0 =A0 =A0return new ActiveMQQueue(((Queue)dest).getQueueNam=
e());
> =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0if (dest instanceof Topic) {
> =A0 =A0 =A0 =A0 =A0 =A0return new ActiveMQTopic(((Topic)dest).getTopicNam=
e());
> =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0throw new JMSException("Could not transform the destinatio=
n into a
> ActiveMQ destination: " + dest);
> =A0 =A0}
>
> --
> View this message in context: http://camel.465427.n5.nabble.com/Problem-w=
ith-ActiveMQ-to-Weblogic-route-tp4578300p4586327.html
> Sent from the Camel - Users mailing list archive at Nabble.com.
>


--=20
http://fusesource.com
http://blog.garytully.com