Mailing-List: contact users-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@camel.apache.org
Received-SPF: pass (nike.apache.org: domain of willem.jiang@gmail.com
 designates 209.85.198.245 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=YaD1wnBLNK9q/IYY4HoNjTVCaZ0RUJF51Rqk9vAj7U9KlYjsjBs22qEGs+YFC32i6v
         G1zdPp16AIQNaBQ4xAh3AgqI7cjfTVSKuNMLij06zZRBdEtBkTfXm11EColS13df64Xf
         ZwfC5RKZg/vW1ephBQh5bxrArsyE4qw58IWYg=
MIME-Version: 1.0
In-Reply-To: <20090210113635.48215fa6@rigi.itserve.ch>
References: <20090210113635.48215fa6@rigi.itserve.ch>
Date: Tue, 10 Feb 2009 21:34:48 +0800
Message-ID: <c52c8a780902100534h650499ffxf40ce0bbd950a88@mail.gmail.com>
Subject: Re: camel-cxf Soap-Fault not returned as 500 http error code
From: Willem Jiang <willem.jiang@gmail.com>
To: users@camel.apache.org
Content-Type: multipart/alternative; boundary=000e0cd179e20ebc3d0462908d02

--000e0cd179e20ebc3d0462908d02
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi Marc,

I just fill a JIRA[1] for it, and will look into it tomorrow.

[1]https://issues.apache.org/activemq/browse/CAMEL-1330

Willem

On Tue, Feb 10, 2009 at 6:36 PM, Marc Giger <gigerstyle@gmx.ch> wrote:

> Hi,
>
> I have (again) the problem that a soap-fault is not returned as 500 code.
>
> This worked fine with camel-cxf 1.3 but not with camel-cxf 1.5. The reason
> seems to be that the cxf response-context is not (correctly?) propagated
> back.
>
> In 1.3 we had the following code to propagate the responseContext back to
> the caller:
>
> CxfProducer line 252:
>
> 248: Object result = cxfClient.dispatch(params, context, ex);
> 249: ex.setOutMessage(response);
> 250: invokingContext.setResponseContent(response, result);
> 251: // copy the response context to the response
> 252: response.putAll(responseContext);
> 253: cxfBinding.storeCxfResponse(exchange, response);
>
> This has changed in 1.5 to
>
> Object result = cxfClient.dispatch(params, context, ex);
> ex.setOutMessage(response);
> invokingContext.setResponseContent(response, result);
> // copy the response context to the response
> CxfBinding.storeCXfResponseContext(response, responseContext);
> CxfBinding.storeCxfResponse(endpoint.getHeaderFilterStrategy(), exchange,
> response);
>
> Which stores the responseContext itself as a new property in the message.
>
> Later in the chain, AbstractHttpDestination searches a RESPONSE_CODE in the
> message:
>
> Integer i = (Integer)outMessage.get(Message.RESPONSE_CODE);
>            if (i != null) {
>                int status = i.intValue();
>                if (HttpURLConnection.HTTP_INTERNAL_ERROR == i) {
>                    Map<Object, Object> pHeaders =
>
>  CastUtils.cast((Map)outMessage.get(Message.PROTOCOL_HEADERS));
>                    if (null != pHeaders &&
> pHeaders.containsKey(PROTOCOL_HEADERS_CONTENT_TYPE)) {
>                        pHeaders.remove(PROTOCOL_HEADERS_CONTENT_TYPE);
>                    }
>                }
>                response.setStatus(status);
>            } else {
>                response.setStatus(HttpURLConnection.HTTP_OK);
>            }
>
> which it doesn't find because the RESPONSE_CODE is stored in the
> ResponseContext which is again a HashMap.
> In this case the access to the RESPONSE_CODE would be:
>
> ((HashMap)outMessage.get("ResonseContext")).get(Message.RESPONSE_CODE)
>
> which can't be the correct solution of course.
>
> So, what do I have to do to get my 500 back?:-)
>
> Thanks & Greets
>
> Marc
>
>
>
>

--000e0cd179e20ebc3d0462908d02--