From issues-return-48570-archive-asf-public=cust-asf.ponee.io@camel.apache.org Mon Jan 15 15:45:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id BD1EA180657 for ; Mon, 15 Jan 2018 15:45:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id ADA9E160C31; Mon, 15 Jan 2018 14:45:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 004EA160C25 for ; Mon, 15 Jan 2018 15:45:03 +0100 (CET) Received: (qmail 66106 invoked by uid 500); 15 Jan 2018 14:45:03 -0000 Mailing-List: contact issues-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list issues@camel.apache.org Received: (qmail 66095 invoked by uid 99); 15 Jan 2018 14:45:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jan 2018 14:45:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9FA9E1805C4 for ; Mon, 15 Jan 2018 14:45:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.911 X-Spam-Level: X-Spam-Status: No, score=-107.911 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id bNtBiBMLfmIf for ; Mon, 15 Jan 2018 14:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2BD5D5F5A4 for ; Mon, 15 Jan 2018 14:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6D09FE099A for ; Mon, 15 Jan 2018 14:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2C28E212FF for ; Mon, 15 Jan 2018 14:45:00 +0000 (UTC) Date: Mon, 15 Jan 2018 14:45:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@camel.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CAMEL-12137) Add Support for Braintree Auth MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CAMEL-12137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326299#comment-16326299 ] ASF GitHub Bot commented on CAMEL-12137: ---------------------------------------- nofuss commented on a change in pull request #2175: CAMEL-12137: camel-braintree - Add Support for Braintree Auth URL: https://github.com/apache/camel/pull/2175#discussion_r161537051 ########## File path: components/camel-braintree/src/main/java/org/apache/camel/component/braintree/BraintreeConfiguration.java ########## @@ -104,7 +108,7 @@ public void setMethodName(String methodName) { } public String getEnvironment() { - return ObjectHelper.notNull(environment, ENVIRONMENT); + return environment; Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Add Support for Braintree Auth > ------------------------------ > > Key: CAMEL-12137 > URL: https://issues.apache.org/jira/browse/CAMEL-12137 > Project: Camel > Issue Type: New Feature > Components: camel-braintree > Reporter: Russ Johnson > Priority: Major > Fix For: 2.21.0 > > > The Braintree Component currently only supports configuration using the Braintree provided merchantId, environment, public key and private key. > Braintree now also supports configuration using an Access Token, which is granted by a merchant to another merchant so that they can process transactions on their behalf. More information can be found here: https://developers.braintreepayments.com/guides/braintree-auth/overview > The Braintree Component should support configuration using either method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)