camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-12111) Reconnect doesn't work if camel is started with rabbit broker initially inaccessible and automaticRecoveryEnabled=true or not set
Date Thu, 04 Jan 2018 15:29:00 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-12111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311502#comment-16311502
] 

ASF GitHub Bot commented on CAMEL-12111:
----------------------------------------

GitHub user jisikoff opened a pull request:

    https://github.com/apache/camel/pull/2164

    CAMEL-12111: Fix reconnect if broker is down on startup.  Also fix so…

    … channels share connections again.  Also fix consumers getting started twice on reconnect
at startup.  Also fix null pointers if automaticRecoveryEnabled is not set on the endpoint.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cinch-financial/camel feature/CAMEL-12111-reconnect-on-start

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2164
    
----
commit 17216a11c6996992a64e3f254c48a5e82b50c12d
Author: Jeremy Isikoff <jisikoff@...>
Date:   2018-01-04T14:42:37Z

    CAMEL-12111: Fix reconnect if broker is down on startup.  Also fix so channels share connections
again.  Also fix consumers getting started twice on reconnect at startup.  Also fix null pointers
if automaticRecoveryEnabled is not set on the endpoint.

----


> Reconnect doesn't work if camel is started with rabbit broker initially inaccessible
and automaticRecoveryEnabled=true or not set
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-12111
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12111
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-rabbitmq
>    Affects Versions: 2.20.1
>            Reporter: Jeremy M Isikoff
>             Fix For: 2.20.2, 2.21.0
>
>
> Starting a camel rabbit consumer with the rabbitmq broker down and then bringing the
broker up used to work before 2.20.1 with automaticRecoveryEnabled=true.  
> The logic added in line 298 of the RabbitConsumer and line 301 now only will recover
in the case if automaticRecoveryEnabled=false by allowing it through to line 303 and opening
a connection for the FIRST TIME.  
>  In addition line 298 null pointers on '&& null' if automaticRecoveryEnabled
wasn't specified at all.
> https://github.com/apache/camel/blob/bad9ed4bb2ce1e258039d96ac80c71a746b0520d/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitConsumer.java#L298
> As of now you can not have automaticRecoveryEnabled either not set or true and handle
have camel work in the startup with broker down and then up use case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message