Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Mon, 4 Dec 2017 08:10:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.13122266.1512160074000.376274.1512375000338@Atlassian.JIRA>
In-Reply-To: <JIRA.13122266.1512160074000@Atlassian.JIRA>
References: <JIRA.13122266.1512160074000@Atlassian.JIRA> <JIRA.13122266.1512160074202@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CAMEL-12057) Missing encoding for query params
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 04 Dec 2017 08:10:04 -0000


    [ https://issues.apache.org/jira/browse/CAMEL-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276426#comment-16276426 ] 

ASF GitHub Bot commented on CAMEL-12057:
----------------------------------------

Github user oscerd closed the pull request at:

    https://github.com/apache/camel/pull/2126


> Missing encoding for query params
> ---------------------------------
>
>                 Key: CAMEL-12057
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12057
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-olingo2
>    Affects Versions: 2.20.1
>         Environment: spring-boot
>            Reporter: Przemek Kubicki
>             Fix For: 2.20.2
>
>
> Hi guys,
> i've a problem with making camel-olingo2 to work with $filter query parameter
> Here is my RouteBuilder situation
> {code:java}
> rest("/olingo2")
>                 .get("tickets").to("direct:olingo2/tickets");
>         from("direct:olingo2/tickets")
>                 .setHeader("CamelOlingo2.$filter", simple("ReporterEmail eq 'user@company.com'"))
>                 .setHeader("CamelOlingo2.$select", simple("ID,Name"))
>                 .to("olingo2://read/ServiceRequestCollection")
> {code}
> I get an exception while parsing endpoint URI (a space in uri)
> {{URISyntaxException: Illegal character in query at index 107: https://myXXXXXX.crm.ondemand.com/sap/c4c/odata/v1/c4codata/ServiceRequestCollection/?$filter=ReporterEmail eq 'user@company.com'&$select=ID,Name
> }}
> It comes basically from Olingo2AppImpl:224
> I tried with
> {{ .setHeader("CamelOlingo2.$filter", simple("ReporterEmail%20eq%20%27user@company.com%27"))
> }}but then it fails in Olingo2AppImpl:222 while parsing filter expression.
> As a conclusion, at Olingo2AppImpl:224 queryParams should be encoded.
> here is my patch https://github.com/przem/camel/commit/e239645cadd7130b27cb85bd713cb71140872865


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)