camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-12056) Add NotifyBuilder.destroy() method
Date Sun, 03 Dec 2017 16:05:00 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-12056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275984#comment-16275984
] 

ASF GitHub Bot commented on CAMEL-12056:
----------------------------------------

GitHub user drekbour opened a pull request:

    https://github.com/apache/camel/pull/2128

    CAMEL-12056 Add NotifyBuilder.destroy() method

    + Java 7 tidy up
    
    Note I used the eventNotifier status in create() to determine "isDestroyed" rather than
an explicit field. We could use the same to replace `created` and integrate both concepts
together.. (I can amend PR if requested)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/drekbour/camel CAMEL-12056

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2128
    
----
commit fbde80bf8da8a9090a0658cd6d55278c469cd280
Author: Marc Carter <drekbour@fastmail.fm>
Date:   2017-12-03T15:14:27Z

    CAMEL-12056: Introduce NotifyBuilder.destroy()

commit 923ed28526c2d7609c7ba6892c41f960ffb2be0b
Author: Marc Carter <drekbour@fastmail.fm>
Date:   2017-12-03T15:34:21Z

    Java 7'isms for NotifyBuilder

----


> Add NotifyBuilder.destroy() method
> ----------------------------------
>
>                 Key: CAMEL-12056
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12056
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.20.1
>            Reporter: Marc Carter
>
> Once constructed, NotifyBuilders remain registered against their CamelContext with no
(neat) means of getting rid of them.
> Dev: Add a destroy() method to complement the create() method. Destroy is irreversible,
object should be unusable after this (much as when !created).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message