Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Thu, 9 Nov 2017 14:06:00 +0000 (UTC)
From: "Viktor Khoroshko (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.13093536.1502295926000.195909.1510236360231@Atlassian.JIRA>
In-Reply-To: <JIRA.13093536.1502295926000@Atlassian.JIRA>
References: <JIRA.13093536.1502295926000@Atlassian.JIRA> <JIRA.13093536.1502295926947@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (CAMEL-11656) Support default directory
 sorter for FileConsumer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 09 Nov 2017 14:06:10 -0000


    [ https://issues.apache.org/jira/browse/CAMEL-11656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245700#comment-16245700 ] 

Viktor Khoroshko edited comment on CAMEL-11656 at 11/9/17 2:05 PM:
-------------------------------------------------------------------

Just sort list of files found alphabetically by default in the code placeholder "// sort there" from above description.


was (Author: oceansize):
Just sort list of files of found alphabetically by default in the code placeholder "// sort there" from above description.

> Support default directory sorter for FileConsumer
> -------------------------------------------------
>
>                 Key: CAMEL-11656
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11656
>             Project: Camel
>          Issue Type: Wish
>          Components: camel-core
>    Affects Versions: 2.19.0
>            Reporter: Viktor Khoroshko
>            Priority: Minor
>             Fix For: Future
>
>
> Hello,
> The current way of sorting consumed files isn't very flexible due to how it's implemented:
> Files are sorted AFTER they're added to in progress repository what in combination with *maxMessagesPerPoll* set to be > 0  and *eagerLimitMaxMessagesPerPoll* set to false forces the *removeExcessiveInProgressFiles* call - which in case of persistent idempotent repository used causes redundant calls to a database. 
> This is not only the issue.
> In my case I have a logic in a custom file filter that a file shouldn't be processed if a file with a same prefix is already in progress while still those files should be processed in a specified order. 
> The issue is that since sorting is performed after each file is added to in progress repository and before added there a file should be accepted by a filter but it will be not  - as a previous file with a same prefix has already been added to in progress repo.
> *Example*: files  - test.001, test.002, test.003
> If test.003 is first in a returned file list then it will be added to in progress repository and next files will not be accepted due to the same prefix. 
> Default sorting would solve this issue. 
> It would be great if default sorter can be specified for *FileConsumer* in the pollDirectory method:
> {code:java}
>   log.trace("Polling directory: {}", directory.getPath());
>         File[] dirFiles = directory.listFiles();
>         if (dirFiles == null || dirFiles.length == 0) {
>             // no files in this directory to poll
>             if (log.isTraceEnabled()) {
>                 log.trace("No files found in directory: {}", directory.getPath());
>             }
>             return true;
>         } else {
>             // we found some files
>             if (log.isTraceEnabled()) {
>                 log.trace("Found {} in directory: {}", dirFiles.length, directory.getPath());
>             }
>         }
>         List<File> files = Arrays.asList(dirFiles);
>        // sort there?
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)