camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11932) For fixed length records crlf field is not honored during un-marshaling
Date Tue, 07 Nov 2017 19:16:00 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242677#comment-16242677
] 

ASF GitHub Bot commented on CAMEL-11932:
----------------------------------------

onders86 commented on a change in pull request #2082: CAMEL-11932 - add new option for fixedlengthcvs
unmarshalling because…
URL: https://github.com/apache/camel/pull/2082#discussion_r149474372
 
 

 ##########
 File path: components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyFixedLengthFactory.java
 ##########
 @@ -561,6 +561,9 @@ private void initFixedLengthRecordParameters() {
                 // Get carriage return parameter
                 crlf = record.crlf();
                 LOG.debug("Carriage return defined for the CSV: {}", crlf);
+                
+                eol = record.eol();
+                LOG.debug("EOL(end-of-line) defined for the CSV: {}", crlf);
 
 Review comment:
   updated..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> For fixed length records crlf field is not honored during un-marshaling 
> ------------------------------------------------------------------------
>
>                 Key: CAMEL-11932
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11932
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-bindy
>    Affects Versions: 2.19.3
>            Reporter: Marcin Domanski
>            Assignee: Önder Sezgin
>            Priority: Minor
>
> Reading documentation [here|http://camel.apache.org/bindy.html] you can find that there
is a {{@FixedLengthRecord.clrf}} annotation parameter described as:
> bq. optional - possible values = WINDOWS,UNIX,MAC, or custom; default value = WINDOWS
- allow to define the carriage return character to use. If you specify a value other than
the three listed before, the value you enter (custom) will be used as the CRLF character(s)
> Unfortunately it seems that this is honored only for marshaling, as for un-marshaling
in {{BindyFixedLengthDataFormat.unmarshal()}} java.util.Scanner.nextLine() is used. This implementation
ignores the crlf parameter during un-marshaling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message