camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11944) Ensure HBaseConfiguration ClassLoader is set correctly
Date Wed, 25 Oct 2017 08:49:00 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218261#comment-16218261
] 

ASF GitHub Bot commented on CAMEL-11944:
----------------------------------------

jamesnetherton opened a new pull request #2058: CAMEL-11944: Ensure HBaseConfiguration ClassLoader
is set correctly
URL: https://github.com/apache/camel/pull/2058
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Ensure HBaseConfiguration ClassLoader is set correctly
> ------------------------------------------------------
>
>                 Key: CAMEL-11944
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11944
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-hbase
>    Affects Versions: 2.20.0
>            Reporter: James Netherton
>            Assignee: James Netherton
>            Priority: Minor
>
> Follow up on CAMEL-11692, my fix in HBaseComponent isn't quite right because a call to
HBaseConfiguration.create() automatically sets the ClassLoader on the HBaseConfiguration object.
Hence the conditional logic that follows is always false.
> I think it'd be better to move [this logic|https://github.com/apache/camel/blob/master/components/camel-hbase/src/main/java/org/apache/camel/component/hbase/HBaseComponent.java#L53-L59]
into the preceding if block where the HBaseConfiguration is created. If folks provide their
own configuration, then it's up to them to make sure they have set the ClassLoader correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message