camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11771) Remove commons-logging import
Date Thu, 14 Sep 2017 14:58:00 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166405#comment-16166405
] 

ASF GitHub Bot commented on CAMEL-11771:
----------------------------------------

GitHub user vrlgohel opened a pull request:

    https://github.com/apache/camel/pull/1935

    CAMEL-11771: Removed commons-logging import

    Switched to slf4j Logging, replacing commons-logging. 
    
    camel-cxf has some tests, which still make use of commons-logging. The tests in package,
org.apache.camel.component.cxf.mtom with class MtomTestHelper.isAwtHeadless method referencing
to few other test classes in the same package. 
    
    The logger value used comes from org.springframework.test.context.junit4.AbstractJUnit4SpringContextTests.logger
and this internally uses commons-logging, 
    http://grepcode.com/file/repo1.maven.org/maven2/org.springframework/spring-test/4.2.0.RELEASE/org/springframework/test/context/junit4/AbstractJUnit4SpringContextTests.java#96
    Hence, i am not sure if we need to make any changes here. 
    
    For the rest, tested with the build, tests & itests,  i see no issues. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vrlgohel/camel-1 CAMEL-11771

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1935.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1935
    
----
commit 7fe2bfee68edfbff6dc5532ea479e2ef4174ba70
Author: Viral Gohel <vrlgohel87@gmail.com>
Date:   2017-09-14T14:43:26Z

    CAMEL-11771: Removed commons-logging import

----


> Remove commons-logging import
> -----------------------------
>
>                 Key: CAMEL-11771
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11771
>             Project: Camel
>          Issue Type: Test
>            Reporter: Claus Ibsen
>            Assignee: Viral Gohel
>             Fix For: 2.20.0
>
>
> We should use slf4j-api instead as there is a few unit test that uses commons-logging
api directly.
> {code}
> davsclaus:/Users/davsclaus/workspace/camel (boot2)/$ git grep "commons\.logging"
> components/camel-cxf/src/test/java/org/apache/camel/component/cxf/mtom/MtomTestHelper.java:
   static boolean isAwtHeadless(org.apache.commons.logging.Log log, org.slf4j.Logger logger)
{
> components/camel-jetty9/src/test/java/org/apache/camel/component/jetty/SpringHttpsRouteTest.java:import
org.apache.commons.logging.Log;
> components/camel-jetty9/src/test/java/org/apache/camel/component/jetty/SpringHttpsRouteTest.java:import
org.apache.commons.logging.LogFactory;
> components/camel-zookeeper-master/src/test/java/org/apache/camel/component/zookeepermaster/CuratorFactoryBean.java:import
org.apache.commons.logging.Log;
> components/camel-zookeeper-master/src/test/java/org/apache/camel/component/zookeepermaster/CuratorFactoryBean.java:import
org.apache.commons.logging.LogFactory;
> components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/FailoverCuratorLeaderRoutePolicyTest.java:import
org.apache.commons.logging.LogFactory;
> components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/FailoverRoutePolicyTest.java:import
org.apache.commons.logging.LogFactory;
> components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/MultiMasterCuratorLeaderRoutePolicyTest.java:import
org.apache.commons.logging.LogFactory;
> parent/pom.xml:      org.apache.commons.logging.*;version="[1.1,2)",
> tests/camel-itest-karaf/src/test/resources/commons-logging.properties:#org.apache.commons.logging.Log=org.apache.commons.logging.impl.Jdk14Logger
> tests/camel-itest-karaf/src/test/resources/commons-logging.properties:org.apache.commons.logging.Log=org.apache.commons.logging.impl.Log4JLogger
> tests/camel-itest/src/test/resources/commons-logging.properties:#org.apache.commons.logging.Log=org.apache.commons.logging.impl.Jdk14Logger
> tests/camel-itest/src/test/resources/commons-logging.properties:org.apache.commons.logging.Log=org.apache.commons.logging.impl.Log4JLogger
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message