camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wilson MacGyver (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11710) trim for fixlength only trim one direction
Date Mon, 28 Aug 2017 13:45:00 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143788#comment-16143788
] 

Wilson MacGyver commented on CAMEL-11710:
-----------------------------------------

the problem is after this change. the basic usage case no longer works. in my case, I'm working
with files that often have spaces on both left and right side of the string. previously, by
setting trim to true, it gets rid of spaces on both sides.

but now, it only trims spaces on one side. I would think this is the most basic usage case,
no?

> trim for fixlength only trim one direction
> ------------------------------------------
>
>                 Key: CAMEL-11710
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11710
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-bindy
>    Affects Versions: 2.19.2
>            Reporter: Wilson MacGyver
>
> I was noticing for bindy my fixedlength fields, where I set trim to true is no longer
working
> then I spotted this
> https://github.com/apache/camel/blob/camel-2.19.2/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyFixedLengthFactory.java#L226
> the problem is
> https://github.com/apache/camel/blob/camel-2.19.2/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyFixedLengthFactory.java#L304
> trim function only trim one direction vs the bultin java string.trim()
> is this change intentional? seems like an odd choice if so. it effectively means I'll
have to call string trim() function on each field that I marked trim=true



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message