Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Mon, 24 Jul 2017 11:54:00 +0000 (UTC)
From: =?utf-8?Q?Rafa=C5=82_Ga=C5=82a_=28JIRA=29?= <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.13089487.1500897116000.314605.1500897240138@Atlassian.JIRA>
In-Reply-To: <JIRA.13089487.1500897116000@Atlassian.JIRA>
References: <JIRA.13089487.1500897116000@Atlassian.JIRA> <JIRA.13089487.1500897116668@jira-lw-us.apache.org>
Subject: [jira] [Updated] (CAMEL-11590) Unnecessary connection opened when
 using custom AS400ConnectionPool
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 24 Jul 2017 11:54:11 -0000


     [ https://issues.apache.org/jira/browse/CAMEL-11590?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafa=C5=82 Ga=C5=82a updated CAMEL-11590:
-------------------------------
    Description:=20
When using a custom *AS400ConnectionPool* for *Jt400Component* (*connection=
Pool* URI parameter), an unnecessary connection is opened to an AS400 syste=
m nevertheless. This happens only when the *resolvePropertyPlaceholders* pr=
operty is set to *true* (there are getters called by reflection at some poi=
nt from *IntrospectionSupport* class).

This connection will never be used when using a custom *AS400ConnectionPool=
*, as the *createEndpoint* method in Jt400Component class checks if we use =
custom or default pool:

{code:java}
@Override
protected Endpoint createEndpoint(String uri, String remaining, Map<String,=
 Object> properties) throws Exception {
    AS400ConnectionPool connectionPool;
    if (properties.containsKey(CONNECTION_POOL)) {
        LOG.trace("AS400ConnectionPool instance specified in the URI - will=
 look it up.");
        =20
        // We have chosen to handle the connectionPool option ourselves, so
        // we must remove it from the given parameter list (see
        // http://camel.apache.org/writing-components.html)
        String poolId =3D properties.remove(CONNECTION_POOL).toString();
        connectionPool =3D EndpointHelper.resolveReferenceParameter(getCame=
lContext(), poolId, AS400ConnectionPool.class, true);
    } else {
       LOG.trace("No AS400ConnectionPool instance specified in the URI - on=
e will be provided.");
       connectionPool =3D getConnectionPool();
    }

    String type =3D remaining.substring(remaining.lastIndexOf(".") + 1).toU=
pperCase();
    Jt400Endpoint endpoint =3D new Jt400Endpoint(uri, this, connectionPool)=
;
    setProperties(endpoint, properties);
    endpoint.setType(Jt400Type.valueOf(type));
    return endpoint;
}
{code}

and uses the one provided instead.

I've attached a patch which changes behaviour of the *createEndpoint* metho=
d to close the previously initialized default connection when the provided =
one should be used instead. This is not a very elegant solution though.

  was:
When using a custom *AS400ConnectionPool* for *Jt400Component* (*connection=
Pool* URI parameter), an unnecessary connection is opened to an AS400 syste=
m nevertheless. This happens only when the *resolvePropertyPlaceholders* pr=
operty is set to *true* (there are getters called by reflection at some poi=
nt from *IntrospectionSupport* class).

This connection will never be used when using a custom *AS400ConnectionPool=
*, as the *createEndpoint* method in Jt400Component class checks if we use =
custom or default pool:

{code:java}
@Override
protected Endpoint createEndpoint(String uri, String remaining, Map<String,=
 Object> properties) throws Exception {
    AS400ConnectionPool connectionPool;
    if (properties.containsKey(CONNECTION_POOL)) {
        LOG.trace("AS400ConnectionPool instance specified in the URI - will=
 look it up.");
        =20
        // We have chosen to handle the connectionPool option ourselves, so
        // we must remove it from the given parameter list (see
        // http://camel.apache.org/writing-components.html)
        String poolId =3D properties.remove(CONNECTION_POOL).toString();
        connectionPool =3D EndpointHelper.resolveReferenceParameter(getCame=
lContext(), poolId, AS400ConnectionPool.class, true);
    } else {
       LOG.trace("No AS400ConnectionPool instance specified in the URI - on=
e will be provided.");
       connectionPool =3D getConnectionPool();
    }

    String type =3D remaining.substring(remaining.lastIndexOf(".") + 1).toU=
pperCase();
    Jt400Endpoint endpoint =3D new Jt400Endpoint(uri, this, connectionPool)=
;
    setProperties(endpoint, properties);
    endpoint.setType(Jt400Type.valueOf(type));
    return endpoint;
}
{code}

and uses the one provided instead.

I've attached a patch which changes behaviour of the *createEndpoint* metho=
d to close the previously initialized default connection when the provided =
one should be used instead.


> Unnecessary connection opened when using custom AS400ConnectionPool
> -------------------------------------------------------------------
>
>                 Key: CAMEL-11590
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11590
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-jt400
>            Reporter: Rafa=C5=82 Ga=C5=82a
>            Priority: Minor
>         Attachments: Jt400Component.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using a custom *AS400ConnectionPool* for *Jt400Component* (*connecti=
onPool* URI parameter), an unnecessary connection is opened to an AS400 sys=
tem nevertheless. This happens only when the *resolvePropertyPlaceholders* =
property is set to *true* (there are getters called by reflection at some p=
oint from *IntrospectionSupport* class).
> This connection will never be used when using a custom *AS400ConnectionPo=
ol*, as the *createEndpoint* method in Jt400Component class checks if we us=
e custom or default pool:
> {code:java}
> @Override
> protected Endpoint createEndpoint(String uri, String remaining, Map<Strin=
g, Object> properties) throws Exception {
>     AS400ConnectionPool connectionPool;
>     if (properties.containsKey(CONNECTION_POOL)) {
>         LOG.trace("AS400ConnectionPool instance specified in the URI - wi=
ll look it up.");
>         =20
>         // We have chosen to handle the connectionPool option ourselves, =
so
>         // we must remove it from the given parameter list (see
>         // http://camel.apache.org/writing-components.html)
>         String poolId =3D properties.remove(CONNECTION_POOL).toString();
>         connectionPool =3D EndpointHelper.resolveReferenceParameter(getCa=
melContext(), poolId, AS400ConnectionPool.class, true);
>     } else {
>        LOG.trace("No AS400ConnectionPool instance specified in the URI - =
one will be provided.");
>        connectionPool =3D getConnectionPool();
>     }
>     String type =3D remaining.substring(remaining.lastIndexOf(".") + 1).t=
oUpperCase();
>     Jt400Endpoint endpoint =3D new Jt400Endpoint(uri, this, connectionPoo=
l);
>     setProperties(endpoint, properties);
>     endpoint.setType(Jt400Type.valueOf(type));
>     return endpoint;
> }
> {code}
> and uses the one provided instead.
> I've attached a patch which changes behaviour of the *createEndpoint* met=
hod to close the previously initialized default connection when the provide=
d one should be used instead. This is not a very elegant solution though.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)