camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11553) Upgrade to Brave 4
Date Sun, 23 Jul 2017 11:44:01 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097604#comment-16097604
] 

Claus Ibsen commented on CAMEL-11553:
-------------------------------------

Ah okay, so its a matter of using the newer api than the older one. A PR is much welcome.

> Upgrade to Brave 4
> ------------------
>
>                 Key: CAMEL-11553
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11553
>             Project: Camel
>          Issue Type: Task
>          Components: camel-zipkin
>    Affects Versions: 2.19.1
>            Reporter: Radek Mensik
>            Assignee: Kevin Earls
>            Priority: Minor
>             Fix For: 2.20.0
>
>
> It would be nice to have up to date library not using deprecated code, because:
> Brave v. 4 allows you to use _brave.Tracing_ so one can easily register https://github.com/openzipkin/brave/tree/master/context/slf4j
which allows you to have in each log line info about spans:
> {code:java}
> 2017-07-17 17:44:08.526  INFO [proxy,b805c5edbe362a7c,b805c5edbe362a7c,true]
> {code}
> Then it is easy to copy and use span id to zipkin UI in case of debugging. (btw currently
there is Long value of span instead of Hexadecimal printed).
> There is possibility to overlap with version 3 and 4 -> https://github.com/openzipkin/brave/tree/master/brave#upgrading-from-brave-3
so this could be good start.
> Also _brave.sampler.Sampler_ should be used in stead of _com.github.kristofa.brave.Sampler_



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message