camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11469) Camel-Hipchat - Configure via xml is broken
Date Tue, 27 Jun 2017 22:00:01 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065547#comment-16065547
] 

ASF GitHub Bot commented on CAMEL-11469:
----------------------------------------

GitHub user w4tson opened a pull request:

    https://github.com/apache/camel/pull/1793

    CAMEL-11469 Use remainder of uri to parse config

    The configuration now uses the remainder of the uri to parse out the properties. This
can now cope with a '//' or not and stops further string manipulation where it isn't needed.
    
    CAMEL-9495 was fixing parsing logic and seemed to knock it out. I'm not super familiar
with camel core but it looks like the 'remaining' URI is already being passed in so it seems
silly to attempt this again?
    
    Also I had to work hard a bit not to introduce a dependency on spring in order to reproduce
this. My work around is to manually load in the route from XML. It's quite clunky the way
I've done it. If there's a smoother way, please advise.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/w4tson/camel CAMEL-11469-hipchat-endpoint-uri-problem

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1793.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1793
    
----
commit 202daa5f8145669880c0d7f61e01ae9a3308c249
Author: Paul Watson <paul.watson@pdwtech.com>
Date:   2017-06-27T21:51:15Z

    CAMEL-11469 Use remainder of uri to parse config
    
    The configuration now uses the remainder of the uri to parse out the properties. This
can now cope with a '//' or not and stops further string manipulation where it isn't needed

----


> Camel-Hipchat - Configure via xml is broken
> -------------------------------------------
>
>                 Key: CAMEL-11469
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11469
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-hipcat
>    Affects Versions: 2.19.1
>            Reporter: Paul Watson
>            Priority: Minor
>
> Declaring a hipchat endpoint in XML misconfigures the same component in the DSL. This
seems to be because at some point via XML the component URI get's normalized and '//' is introduced.
> This means a component of 
> {{<to uri="hipchat:https:myhipchatserver.com:443?authToken?=abc" />}}
> Is actually configured to the default api.hipchat.com.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message