camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ronny Aerts (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11273) ReloadStrategySupport does take changed routeContext files into account
Date Sat, 13 May 2017 14:56:05 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009360#comment-16009360
] 

Ronny Aerts commented on CAMEL-11273:
-------------------------------------

I'm not familiar yet with pull requests. 

I re-cloned https://github.com/apache/camel.git to my local machine.
I created a pull request on the github website with number 1693. 
I locally executed a "git pull https://github.com/apache/camel camel-2.19.x" (as the mail
suggest) but this went wrong because of "Automatic merge failed; fix conflicts and then commit
the result." message. 

I don't know how to continue and my local folder is messed up. 

> ReloadStrategySupport does take changed routeContext files into account
> -----------------------------------------------------------------------
>
>                 Key: CAMEL-11273
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11273
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.19.0
>            Reporter: Ronny Aerts
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 2.19.1, 2.20.0
>
>
> I saw in the camel 2.19.0 release notes that xml routes could be reloaded automatically
which woke my interest (since we only use xml routes and no java at all). I tried it by specifying
the fileWatcherDirectory in my pom.xml (in the camel-maven-plugin configuration) and it worked
fine for me. I ran it from within eclipse.
> The point is that our camelcontext only holds routeContextRef entries and no real routes.
I tried again by specifying the location src/main/resources (where the routecontext files
are) but this does not seem to work, no updates are seen. 
> Claus point me to look in the source code and I saw that ReloadStrategySupport.java holds
line 76:
> {code}
> dom = XmlLineNumberParser.parseXml(new ByteArrayInputStream(xml.getBytes()), null, "camelContext,routes",
"http://camel.apache.org/schema/spring");
> {code}
> which means that routes from a routeContext are NOT reloaded. 
> This could be solved by changing the line to:
> {code}
> dom = XmlLineNumberParser.parseXml(new ByteArrayInputStream(xml.getBytes()), null, "camelContext,routes,routeContext",
"http://camel.apache.org/schema/spring");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message