camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11273) ReloadStrategySupport does take changed routeContext files into account
Date Sat, 13 May 2017 14:18:05 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009354#comment-16009354
] 

ASF GitHub Bot commented on CAMEL-11273:
----------------------------------------

GitHub user ronnyaerts opened a pull request:

    https://github.com/apache/camel/pull/1693

    CAMEL-11273: also process routeContext routes in auto ReloadStrategy

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/camel camel-2.19.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1693.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1693
    
----
commit 6cb00233e8e94dc9028f9ec02b5580d04de24c66
Author: Gregor Zurowski <gregor@zurowski.org>
Date:   2017-04-29T20:44:54Z

    [maven-release-plugin] prepare release camel-2.19.0

commit 3c909c8ab81109dfb4164427c53770ddf17d2430
Author: Gregor Zurowski <gregor@zurowski.org>
Date:   2017-04-29T20:45:42Z

    [maven-release-plugin] prepare for next development iteration

commit a7144f3b0e3d05165ab783dd02a0c816b0f64b8c
Author: Gregor Zurowski <gregor@zurowski.org>
Date:   2017-05-05T07:27:07Z

    Add schema references for release 2.18.3
    
    Signed-off-by: Gregor Zurowski <gregor@zurowski.org>

commit 11c66e6756adc546955204666bdaa5ba32eb5f2f
Author: Gregor Zurowski <gregor@zurowski.org>
Date:   2017-05-05T07:34:50Z

    Add schema references for release 2.19.0
    
    Signed-off-by: Gregor Zurowski <gregor@zurowski.org>

commit c4d99ac146d5c3a6f9b18ba533c32800de410f91
Author: Sami Nurminen <snurmine@gmail.com>
Date:   2017-05-02T17:39:01Z

    https://stackoverflow.com/questions/43607569/simple-expression-in-sql-stored-component
Added colon to Simple and parameter grammar

commit 0aeba63ac67fe9a5d6843df28f4ab060676bcf56
Author: Claus Ibsen <davsclaus@apache.org>
Date:   2017-05-08T12:11:43Z

    Regen

commit 118b37ef4b2a477e7529cd0770a3a4a4135aca89
Author: onders86 <ondersezgin@gmail.com>
Date:   2017-05-08T08:38:18Z

    CAMEL-11221- 409(which was a wrong default value) should have been 4096

commit a713e3e65a16046ca573f13181e4ae95e18f8946
Author: Claus Ibsen <davsclaus@apache.org>
Date:   2017-05-08T16:09:33Z

    CAMEL-11239: camel-catalog-maven - Remove sl4j logger as it causes tooling classloading
pain

commit 93c72f42f3a76a1e9c2c8fee2fa868cf36808461
Author: lburgazzoli <lburgazzoli@gmail.com>
Date:   2017-05-02T13:44:48Z

    CAMEL-11225: Deadlock in component creation

commit 90e2c6a8ba162d358f12fe97c8d244f5fb701485
Author: lburgazzoli <lburgazzoli@gmail.com>
Date:   2017-05-08T13:06:53Z

    CAMEL-11225: fix tests

commit 103b09d1dda7c76b4509b07e10b7b71aeac361ae
Author: Gary Brown <gary@brownuk.com>
Date:   2017-05-10T15:48:57Z

    CAMEL-11258 Use TracerResolver to locate Tracer without modifying code/config

commit f070c4f003341af97e0bdb991cfa15a9faed71b2
Author: Christian Schneider <chris@die-schneider.net>
Date:   2017-05-05T14:32:27Z

    [CAMEL-11229] Avoid recursion in onException

commit 9d65602039ca597e77dbe88a6069a14ab43c6046
Author: Zoran Regvart <zregvart@apache.org>
Date:   2017-05-08T09:54:59Z

    CAMEL-11229 Infinite recursion if exception hap...
    
    ...pens inside exception handler
    
    A bit simpler unit test and reformatted source code.

commit 3190a38f916c19e37cd5015359fc3399e3b8eb07
Author: Claus Ibsen <davsclaus@apache.org>
Date:   2017-05-10T11:10:57Z

    CAMEL-11229: Add fail-safe in fatal error handler to detect circular looping

commit 133ad76d597661afb30a7e5def068e14e792c899
Author: Claus Ibsen <davsclaus@apache.org>
Date:   2017-05-11T09:08:37Z

    CAMEL-11229: Add TODO for that weird test which fails run manually but not with mvn clean
install

commit b69dd8259187d5ebaea9d0fdf1179c9e676bd971
Author: Claus Ibsen <davsclaus@apache.org>
Date:   2017-05-11T09:12:28Z

    CAMEL-11229: Polished

commit 7fda1675bf971c2bda5af724a67a1cea3c33aa27
Author: Claus Ibsen <davsclaus@apache.org>
Date:   2017-05-11T09:55:56Z

    CAMEL-11229: Rename due typo

commit bddcd40ab14ad5d8c8fe124674c1d9ff827d3e95
Author: Claus Ibsen <davsclaus@apache.org>
Date:   2017-05-11T11:17:14Z

    CAMEL-11229: Mark exchange as circulr detected for error handler.

commit 3d82d1711d94c3e631ead12cfdcf3467248b07ab
Author: onders86 <ondersezgin@gmail.com>
Date:   2017-05-11T13:25:59Z

    CAMEL-11263 - set component options on the endpoint first, and then let endpoint parameters
override

commit f8a05797db9ff83f255c9232cfa48380e470b246
Author: Ramu <kkakarla@redhat.com>
Date:   2017-05-12T05:51:45Z

    camel-spring-dm is deprecated :CAMEL-11059

commit 9b2d5aacaf0a73759e075434bfd9151fcd36fa12
Author: Paolo Antinori <pantinor@redhat.com>
Date:   2017-05-12T14:09:52Z

    CAMEL-11269 - fix for URISupport and masking secrets

----


> ReloadStrategySupport does take changed routeContext files into account
> -----------------------------------------------------------------------
>
>                 Key: CAMEL-11273
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11273
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.19.0
>            Reporter: Ronny Aerts
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 2.19.1, 2.20.0
>
>
> I saw in the camel 2.19.0 release notes that xml routes could be reloaded automatically
which woke my interest (since we only use xml routes and no java at all). I tried it by specifying
the fileWatcherDirectory in my pom.xml (in the camel-maven-plugin configuration) and it worked
fine for me. I ran it from within eclipse.
> The point is that our camelcontext only holds routeContextRef entries and no real routes.
I tried again by specifying the location src/main/resources (where the routecontext files
are) but this does not seem to work, no updates are seen. 
> Claus point me to look in the source code and I saw that ReloadStrategySupport.java holds
line 76:
> {code}
> dom = XmlLineNumberParser.parseXml(new ByteArrayInputStream(xml.getBytes()), null, "camelContext,routes",
"http://camel.apache.org/schema/spring");
> {code}
> which means that routes from a routeContext are NOT reloaded. 
> This could be solved by changing the line to:
> {code}
> dom = XmlLineNumberParser.parseXml(new ByteArrayInputStream(xml.getBytes()), null, "camelContext,routes,routeContext",
"http://camel.apache.org/schema/spring");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message