camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicola Ferraro (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11125) camel-reactive-streams - Consumer should allow to not refill so frequently
Date Mon, 08 May 2017 11:40:04 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000628#comment-16000628
] 

Nicola Ferraro commented on CAMEL-11125:
----------------------------------------

As further improvement, in the case of unbounded number of in-flight exchanges (max-inflight
<= 0), we can request Long.MAX_VALUE and we won't need to refill anymore, because Long.MAX_VALUE
means unbounded as per subscription rule 17 (https://github.com/reactive-streams/reactive-streams-jvm).

> camel-reactive-streams - Consumer should allow to not refill so frequently
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-11125
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11125
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-reactive-streams
>    Affects Versions: 2.19.0
>            Reporter: Claus Ibsen
>            Assignee: Nicola Ferraro
>            Priority: Minor
>
> Every time a consumer has completed onNext it calculates a refill, and because it has
completed 1 message, it will always ask for at least 1 message. 
> This happens even if there is 127 messages already in the buffer. 
> We should probably have some way of having a low/high watermark so if the buffer has
many messages already we dont need to refill so frequently.
> This happens in the code: org.apache.camel.component.reactive.streams.engine.CamelSubscriber#onNext
> By having those watermark threshold we allow to not be so chatty and request data all
the time, but instead request data in more bulks. Otherwise chances are that we just keep
requesting = 1 all the time.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message