camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-11054) Create SPI for Log EIP to enable other components to intercept/enrich logged messages
Date Thu, 30 Mar 2017 14:51:42 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-11054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949222#comment-15949222
] 

ASF GitHub Bot commented on CAMEL-11054:
----------------------------------------

GitHub user igarashitm opened a pull request:

    https://github.com/apache/camel/pull/1585

    CAMEL-11054 Create SPI for Log EIP to enable other components to inte…

    …rcept/enrich logged messages
    
    # PLEASE DO NOT MERGE - this is continued from https://github.com/apache/camel/pull/1559
    
    Hi @davsclaus , @objectiser , 
    
    Here is an outline sketch for the CAMEL-11054. Let's start from here:
    * adds `addCamelLoggerListener()`/`getCamelLoggerListeners()` on `CamelContext`
    * `CamelLogger` holds a list of `CamelLoggerListener`
    * for Log EIP, `LogDefinition` copies `CamelLoggerListener`s from `CamelContext` to `CamelLogger`
    * for Log Component, `LogEndpoint` copies `CamelLoggerListener`s from `CamelContext` to
`CamelLogger`
    * `CamelLoggerListener#onLog()` to receive a log event and return an enriched log message
    
    Questions:
    * do we want to extract `enrich()` from `onLog()` so it could be done separately?
    * do we want separated handler like `onWarn()`, `onInfo()` and etc. rather than `onLog()`?
    * any other event we want to handle in `CamelLoggerListener`?
    * As both of Log EIP and Component use `CamelLogger`, it's easy to add it on both of them.
Is it OK or do we want it only on Log EIP?
    
    Any comment would be appreciated!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/igarashitm/camel CAMEL-11054

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1585
    
----

----


> Create SPI for Log EIP to enable other components to intercept/enrich logged messages
> -------------------------------------------------------------------------------------
>
>                 Key: CAMEL-11054
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11054
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Gary Brown
>            Assignee: Tomohisa Igarashi
>             Fix For: 2.19.0
>
>
> Related to the discussion here: https://github.com/apache/camel/pull/1559#issuecomment-288659557
> Provide a SPI to enable components (e.g. camel-opentracing) to be notified when a camel
route uses the log EIP to record information, and potentially enrich/influence the logged
information.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message