camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Netherton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10750) Suppression of JSR356 should be restricted to Jetty
Date Wed, 01 Mar 2017 10:41:45 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889948#comment-15889948
] 

James Netherton commented on CAMEL-10750:
-----------------------------------------

Yes, I did take a brief look at it. I removed the WEBSOCKET_SUPPRESS_JSR356 flag and the tests
all passed fine (which run with Jetty 9.3.x).

I'll do some additional testing and try to get a PR in this week.

> Suppression of JSR356 should be restricted to Jetty
> ---------------------------------------------------
>
>                 Key: CAMEL-10750
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10750
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-atmosphere-websocket
>            Reporter: James Netherton
>            Assignee: James Netherton
>             Fix For: 2.19.0
>
>
> We have some logic that sets up the atmosphere websocket config in the WebsocketConsumer.
> https://github.com/apache/camel/blame/52a739feb9da8acd29067304c7c8356bbc5ef4dd/components/camel-atmosphere-websocket/src/main/java/org/apache/camel/component/atmosphere/websocket/WebsocketConsumer.java#L53-L54
> If suppression of JSR 356 is specific to running on Jetty, why do we enforce it globally?
> I'm trying to integrate this component on WildFly so it seems reasonable to me that I
should be able to make use of JSR 356.
> Maybe we should only apply this restriction if Jetty is detected? 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message